mirror of
https://github.com/nushell/nushell.git
synced 2024-10-17 07:42:53 +02:00
2bacc29d30
# Description This PR changes some commands that previously accepted row conditions (like `$it > 5`) as parameter to accept closures instead. The reasons are: a) The commands would need to move into parser keywords in the future while they feel more like commands to be implemented in Nushell code as a part of standard library. b) In scripts, it is useful to store the predicate condition in a variable which you can't do with row conditions. c) These commands are not used that often to benefit enough from the shorter row condition syntax # User-Facing Changes The following commands now accept **closure** instead of a **row condition**: - `take until` - `take while` - `skip until` - `skip while` - `any` - `all` This is a part of an effort to move away from shape-directed parsing. Related PR: https://github.com/nushell/nushell/pull/7365 # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
106 lines
2.4 KiB
Rust
106 lines
2.4 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn checks_any_row_is_true() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
echo [ "Ecuador", "USA", "New Zealand" ]
|
|
| any {|it| $it == "New Zealand" }
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn checks_any_column_of_a_table_is_true() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
[ first_name, last_name, rusty_at, likes ];
|
|
[ Andrés, Robalino, 10/11/2013, 1 ]
|
|
[ Jonathan, Turner, 10/12/2013, 1 ]
|
|
[ Darren, Schroeder, 10/11/2013, 1 ]
|
|
[ Yehuda, Katz, 10/11/2013, 1 ]
|
|
]
|
|
| any {|x| $x.rusty_at == 10/12/2013 }
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn checks_if_any_returns_error_with_invalid_command() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[red orange yellow green blue purple] | any {|it| ($it | st length) > 4 }
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("can't run executable") || actual.err.contains("did you mean"));
|
|
}
|
|
|
|
#[test]
|
|
fn works_with_1_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | any {|e| print $e | false }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "123false");
|
|
}
|
|
|
|
#[test]
|
|
fn works_with_0_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | any { print $in | false }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "123false");
|
|
}
|
|
|
|
#[test]
|
|
fn early_exits_with_1_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | any {|e| print $e | true }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "1true");
|
|
}
|
|
|
|
#[test]
|
|
fn early_exits_with_0_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | any { print $in | true }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "1true");
|
|
}
|
|
|
|
#[test]
|
|
fn uses_optional_index_argument() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[7 8 9] | any {|el ind| print $ind | false }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "012false");
|
|
}
|
|
|
|
#[test]
|
|
fn unique_env_each_iteration() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"[1 2] | any { print ($env.PWD | str ends-with 'formats') | cd '/' | false } | to nuon"
|
|
);
|
|
|
|
assert_eq!(actual.out, "truetruefalse");
|
|
}
|