mirror of
https://github.com/nushell/nushell.git
synced 2024-12-04 22:33:50 +01:00
29e809ad77
# Description This PR allows the `values` command to support lazy records. closes https://github.com/nushell/nushell/issues/10417 ### Before ```nushell sys | values Error: nu:🐚:only_supports_this_input_type × Input type not supported. ╭─[entry #1:1:1] 1 │ sys | values · ─┬─ ───┬── · │ ╰── only record or table input data is supported · ╰── input type: record<host: record<name: string, os_version: string, long_os_version: string, kernel_version: string, hostname: string, uptime: duration, boot_time: string, sessions: list<any>>, cpu: table<name: string, brand: string, freq: int, cpu_usage: float, load_average: string, vendor_id: string>, disks: table<device: string, type: string, mount: string, total: filesize, free: filesize, removable: bool, kind: string>, mem: record<total: filesize, free: filesize, used: filesize, available: filesize, swap total: filesize, swap free: filesize, swap used: filesize>, temp: list<any>, net: table<name: string, sent: filesize, recv: filesize>> ╰──── ``` ### After ```nushell ❯ sys | values ╭─┬─────────────────╮ │0│{record 8 fields}│ │1│[table 16 rows] │ │2│[table 1 row] │ │3│{record 7 fields}│ │4│[list 0 items] │ │5│[table 5 rows] │ ╰─┴─────────────────╯ ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
90 lines
2.1 KiB
Rust
90 lines
2.1 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn insert_the_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| insert dev-dependencies.new_assertions "0.7.0"
|
|
| get dev-dependencies.new_assertions
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
}
|
|
|
|
#[test]
|
|
fn doesnt_convert_record_to_table() {
|
|
let actual = nu!("{a:1} | insert b 2 | to nuon");
|
|
|
|
assert_eq!(actual.out, "{a: 1, b: 2}");
|
|
}
|
|
|
|
#[test]
|
|
fn insert_the_column_conflict() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| insert dev-dependencies.pretty_assertions "0.7.0"
|
|
"#
|
|
));
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("column 'pretty_assertions' already exists"));
|
|
}
|
|
|
|
#[test]
|
|
fn insert_into_list() {
|
|
let actual = nu!("[1, 2, 3] | insert 1 abc | to json -r");
|
|
|
|
assert_eq!(actual.out, r#"[1,"abc",2,3]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_into_list_begin() {
|
|
let actual = nu!("[1, 2, 3] | insert 0 abc | to json -r");
|
|
|
|
assert_eq!(actual.out, r#"["abc",1,2,3]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_into_list_end() {
|
|
let actual = nu!("[1, 2, 3] | insert 3 abc | to json -r");
|
|
|
|
assert_eq!(actual.out, r#"[1,2,3,"abc"]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_past_end_list() {
|
|
let actual = nu!("[1, 2, 3] | insert 5 abc | to json -r");
|
|
|
|
assert_eq!(actual.out, r#"[1,2,3,null,null,"abc"]"#);
|
|
}
|
|
|
|
#[test]
|
|
fn insert_uses_enumerate_index() {
|
|
let actual = nu!(
|
|
"[[a]; [7] [6]] | enumerate | insert b {|el| $el.index + 1 + $el.item.a } | flatten | to nuon"
|
|
);
|
|
|
|
assert_eq!(actual.out, "[[index, a, b]; [0, 7, 8], [1, 6, 8]]");
|
|
}
|
|
|
|
#[test]
|
|
fn insert_support_lazy_record() {
|
|
let actual =
|
|
nu!(r#"let x = (lazy make -c ["h"] -g {|a| $a | str upcase}); $x | insert a 10 | get a"#);
|
|
assert_eq!(actual.out, "10");
|
|
}
|
|
|
|
#[test]
|
|
fn lazy_record_test_values() {
|
|
let actual = nu!(
|
|
r#"lazy make --columns ["haskell", "futures", "nushell"] --get-value { |lazything| $lazything + "!" } | values | length"#
|
|
);
|
|
assert_eq!(actual.out, "3");
|
|
}
|