mirror of
https://github.com/nushell/nushell.git
synced 2025-02-28 00:12:36 +01:00
# Description This PR tights input/output type-checking a bit more. There are a lot of commands that don't have correct input/output types, so part of the effort is updating them. This PR now contains updates to commands that had wrong input/output signatures. It doesn't add examples for these new signatures, but that can be follow-up work. # User-Facing Changes BREAKING CHANGE BREAKING CHANGE This work enforces many more checks on pipeline type correctness than previous nushell versions. This strictness may uncover incompatibilities in existing scripts or shortcomings in the type information for internal commands. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
106 lines
2.9 KiB
Rust
106 lines
2.9 KiB
Rust
use nu_engine::CallExt;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, IntoPipelineData, PipelineData, ShellError, Signature, SyntaxShape, Type,
|
|
Value,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct StrJoin;
|
|
|
|
impl Command for StrJoin {
|
|
fn name(&self) -> &str {
|
|
"str join"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("str join")
|
|
.input_output_types(vec![
|
|
(Type::List(Box::new(Type::Any)), Type::String),
|
|
(Type::String, Type::String),
|
|
])
|
|
.optional(
|
|
"separator",
|
|
SyntaxShape::String,
|
|
"optional separator to use when creating string",
|
|
)
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Concatenate multiple strings into a single string, with an optional separator between each."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["collect", "concatenate"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let separator: Option<String> = call.opt(engine_state, stack, 0)?;
|
|
|
|
let config = engine_state.get_config();
|
|
|
|
// let output = input.collect_string(&separator.unwrap_or_default(), &config)?;
|
|
// Hmm, not sure what we actually want. If you don't use debug_string, Date comes out as human readable
|
|
// which feels funny
|
|
let mut strings: Vec<String> = vec![];
|
|
|
|
for value in input {
|
|
match value {
|
|
Value::Error { error } => {
|
|
return Err(*error);
|
|
}
|
|
value => {
|
|
strings.push(value.debug_string("\n", config));
|
|
}
|
|
}
|
|
}
|
|
|
|
let output = if let Some(separator) = separator {
|
|
strings.join(&separator)
|
|
} else {
|
|
strings.join("")
|
|
};
|
|
|
|
Ok(Value::String {
|
|
val: output,
|
|
span: call.head,
|
|
}
|
|
.into_pipeline_data())
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Create a string from input",
|
|
example: "['nu', 'shell'] | str join",
|
|
result: Some(Value::test_string("nushell")),
|
|
},
|
|
Example {
|
|
description: "Create a string from input with a separator",
|
|
example: "['nu', 'shell'] | str join '-'",
|
|
result: Some(Value::test_string("nu-shell")),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(StrJoin {})
|
|
}
|
|
}
|