mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 16:33:37 +01:00
7926e4ab6d
# Description Prevent `rustflags` build configuration from being ignored in github actions ci workflows. [actions-rust-lang/setup-rust-toolchain](https://github.com/actions-rust-lang/setup-rust-toolchain/) used in ci workflows sets `RUSTFLAGS="-D warnings"` env variable by default. It has priority over some other sources of `rustflags` as described in [the cargo reference](https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags). Nushell is using `target.x86_64-pc-windows-msvc.rustflags` to statically link MSVC runtime in windows platform, but this config is being ignored in ci workflows. By unsetting `RUSTFLAGS` env variable, `rustflags` build configurations will be properly used in ci workflows. I assume that this was the cause of the installer verification failures on the recent winget submission PRs. For more details, refer discussions in https://github.com/microsoft/winget-pkgs/pull/106977 and https://github.com/nushell/nushell/pull/9322#issuecomment-1602932971. # User-Facing Changes Pre-built releases for windows that are created by the release ci workflow will now contain statically linked MSVC runtime. # Tests + Formatting Confirmed successful installation in a windows sandbox instance, which was failing before. It also contains changes made in #9514. Release ci workflow: https://github.com/wolimst/nushell/actions/runs/5357440849 Installer: https://github.com/wolimst/nushell/releases/tag/0.81.0-test # After Submitting Need to check the installer verification result in a winget submission PR for the next release, if this PR gets merged.
104 lines
2.7 KiB
YAML
104 lines
2.7 KiB
YAML
#
|
|
# REF:
|
|
# 1. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymatrixinclude
|
|
#
|
|
name: Create Release Draft
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
push:
|
|
tags: ["[0-9]+.[0-9]+.[0-9]+*"]
|
|
|
|
defaults:
|
|
run:
|
|
shell: bash
|
|
|
|
jobs:
|
|
all:
|
|
name: All
|
|
|
|
strategy:
|
|
matrix:
|
|
target:
|
|
- aarch64-apple-darwin
|
|
- x86_64-apple-darwin
|
|
- x86_64-pc-windows-msvc
|
|
- aarch64-pc-windows-msvc
|
|
- x86_64-unknown-linux-gnu
|
|
- x86_64-unknown-linux-musl
|
|
- aarch64-unknown-linux-gnu
|
|
extra: ['bin']
|
|
include:
|
|
- target: aarch64-apple-darwin
|
|
os: macos-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-apple-darwin
|
|
os: macos-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-pc-windows-msvc
|
|
extra: 'bin'
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-pc-windows-msvc
|
|
extra: msi
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: aarch64-pc-windows-msvc
|
|
extra: 'bin'
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: aarch64-pc-windows-msvc
|
|
extra: msi
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-unknown-linux-gnu
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
- target: x86_64-unknown-linux-musl
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
- target: aarch64-unknown-linux-gnu
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
|
|
runs-on: ${{matrix.os}}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Update Rust Toolchain Target
|
|
run: |
|
|
echo "targets = ['${{matrix.target}}']" >> rust-toolchain.toml
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.5.0
|
|
with:
|
|
rustflags: ''
|
|
|
|
- name: Setup Nushell
|
|
uses: hustcer/setup-nu@v3
|
|
with:
|
|
version: 0.81.0
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Release Nu Binary
|
|
id: nu
|
|
run: nu .github/workflows/release-pkg.nu
|
|
env:
|
|
OS: ${{ matrix.os }}
|
|
REF: ${{ github.ref }}
|
|
TARGET: ${{ matrix.target }}
|
|
_EXTRA_: ${{ matrix.extra }}
|
|
TARGET_RUSTFLAGS: ${{ matrix.target_rustflags }}
|
|
|
|
# REF: https://github.com/marketplace/actions/gh-release
|
|
- name: Publish Archive
|
|
uses: softprops/action-gh-release@v0.1.13
|
|
if: ${{ startsWith(github.ref, 'refs/tags/') }}
|
|
with:
|
|
draft: true
|
|
files: ${{ steps.nu.outputs.archive }}
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|