mirror of
https://github.com/nushell/nushell.git
synced 2025-05-19 17:30:45 +02:00
# Description Continuing from #12568, this PR further reduces the size of `Expr` from 64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and `Type` from 32 to 24 bytes. This was accomplished by: - for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`), merging the fields into new AST struct types and then boxing this struct (e.g. `Expr::Thing(Box<ABC>)`). - replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and `Expression`s should rarely be mutated, if at all, so this optimization makes sense. By reducing the size of these types, I didn't notice a large performance improvement (at least compared to #12568). But this PR does reduce the memory usage of nushell. My config is somewhat light so I only noticed a difference of 1.4MiB (38.9MiB vs 37.5MiB). --------- Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
97 lines
2.7 KiB
Rust
97 lines
2.7 KiB
Rust
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct LoadEnv;
|
|
|
|
impl Command for LoadEnv {
|
|
fn name(&self) -> &str {
|
|
"load-env"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Loads an environment update from a record."
|
|
}
|
|
|
|
fn signature(&self) -> nu_protocol::Signature {
|
|
Signature::build("load-env")
|
|
.input_output_types(vec![
|
|
(Type::record(), Type::Nothing),
|
|
(Type::Nothing, Type::Nothing),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.optional(
|
|
"update",
|
|
SyntaxShape::Record(vec![]),
|
|
"The record to use for updates.",
|
|
)
|
|
.category(Category::FileSystem)
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let arg: Option<Record> = call.opt(engine_state, stack, 0)?;
|
|
let span = call.head;
|
|
|
|
let record = match arg {
|
|
Some(record) => record,
|
|
None => match input {
|
|
PipelineData::Value(Value::Record { val, .. }, ..) => val.into_owned(),
|
|
_ => {
|
|
return Err(ShellError::UnsupportedInput {
|
|
msg: "'load-env' expects a single record".into(),
|
|
input: "value originated from here".into(),
|
|
msg_span: span,
|
|
input_span: input.span().unwrap_or(span),
|
|
})
|
|
}
|
|
},
|
|
};
|
|
|
|
for prohibited in ["FILE_PWD", "CURRENT_FILE", "PWD"] {
|
|
if record.contains(prohibited) {
|
|
return Err(ShellError::AutomaticEnvVarSetManually {
|
|
envvar_name: prohibited.to_string(),
|
|
span: call.head,
|
|
});
|
|
}
|
|
}
|
|
|
|
for (env_var, rhs) in record {
|
|
stack.add_env_var(env_var, rhs);
|
|
}
|
|
Ok(PipelineData::empty())
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Load variables from an input stream",
|
|
example: r#"{NAME: ABE, AGE: UNKNOWN} | load-env; $env.NAME"#,
|
|
result: Some(Value::test_string("ABE")),
|
|
},
|
|
Example {
|
|
description: "Load variables from an argument",
|
|
example: r#"load-env {NAME: ABE, AGE: UNKNOWN}; $env.NAME"#,
|
|
result: Some(Value::test_string("ABE")),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::LoadEnv;
|
|
|
|
#[test]
|
|
fn examples_work_as_expected() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(LoadEnv {})
|
|
}
|
|
}
|