mirror of
https://github.com/nushell/nushell.git
synced 2025-01-21 13:50:11 +01:00
81baf53814
Closes #6174 # Description This PR aims to improve the performance of `ls` within large directories. `ls` now delegates the metadata collection to a thread in its thread pool. Before: ![image](https://github.com/user-attachments/assets/1967ab78-177c-485f-9b2f-f9d625678171) Now: ![image](https://github.com/user-attachments/assets/fc215d0a-4b26-4791-a3a1-77cecff133e2) # User-Facing Changes If an error occurs while file metadata is being collected in another thread, the `ls` command now notifies the user about this error by sending an error value through a channel (which then gets collected into an iterator and shown to the user later on). However, if an error occurs _while_ sending this error value to the channel (i.e the resulting value iterator has been dropped), then the user is not notified of this error. I think this behavior is acceptable, since behavior only occurs when the `ls` pipeline has been dropped and the user is no longer interested in output from `ls`. # Tests + Formatting I do not know if it is a good idea to test this performance with `timeit`, since it can be unreliable. |
||
---|---|---|
.. | ||
src | ||
tests | ||
Cargo.toml | ||
LICENSE | ||
README.md |
This crate contains the majority of our commands
We allow ourselves to move some of the commands in nu-command
to nu-cmd-*
crates as needed.
Internal Nushell crate
This crate implements components of Nushell and is not designed to support plugin authors or other users directly.