nushell/crates/nu-protocol/src
Wind 87c5f6e455
ls, rm, cp, open, touch, mkdir: Don't expand tilde if input path is quoted string or a variable. (#12232)
# Description
Fixes:  #11887
Fixes: #11626

This pr unify the tilde expand behavior over several filesystem relative
commands. It follows the same rule with glob expansion:
|  command  |  result |
| ----------- |  ------ |
| ls ~/aaa  | expand tilde
| ls "~/aaa"  | don't expand tilde
| let f = "~/aaa"; ls $f | don't expand tilde, if you want to: use `ls
($f \| path expand)`
| let f: glob = "~/aaa"; ls $f | expand tilde, they don't expand on
`mkdir`, `touch` comamnd.

Actually I'm not sure for 4th item, currently it's expanding is just
because it followes the same rule with glob expansion.

### About the change
It changes `expand_path_with` to accept a new argument called
`expand_tilde`, if it's true, expand it, if not, just keep it as `~`
itself.

# User-Facing Changes
After this change, `ls "~/aaa"` won't expand tilde.

# Tests + Formatting
Done
2024-03-25 10:08:38 +08:00
..
ast Address feedback from PR #12229 (#12242) 2024-03-20 20:16:18 +01:00
config Keep plugins persistently running in the background (#12064) 2024-03-09 17:10:22 -06:00
debugger IO and redirection overhaul (#11934) 2024-03-14 15:51:55 -05:00
engine Send LSP Completion Item Kind (#11443) 2024-03-24 20:14:12 -05:00
errors bump rust-toolchain to 1.75.0 (#12258) 2024-03-21 13:23:39 -05:00
pipeline_data Misc doc fixes (#12266) 2024-03-23 07:26:08 -05:00
plugin Misc doc fixes (#12266) 2024-03-23 07:26:08 -05:00
value ls, rm, cp, open, touch, mkdir: Don't expand tilde if input path is quoted string or a variable. (#12232) 2024-03-25 10:08:38 +08:00
alias.rs IO and redirection overhaul (#11934) 2024-03-14 15:51:55 -05:00
did_you_mean.rs Improve case insensitivity consistency (#10884) 2023-11-08 23:58:54 +01:00
eval_base.rs IO and redirection overhaul (#11934) 2024-03-14 15:51:55 -05:00
eval_const.rs IO and redirection overhaul (#11934) 2024-03-14 15:51:55 -05:00
example.rs Fix ignored clippy lints (#12160) 2024-03-11 19:46:04 +01:00
id.rs Add virtual path abstraction layer (#9245) 2023-05-23 23:48:50 +03:00
lev_distance.rs Suggest existing variables on not found (#8902) 2023-05-02 18:17:14 +03:00
lib.rs Restructure nu-protocol in more meaningful units (#11917) 2024-03-10 18:45:45 +01:00
module.rs Error on use path item1 item2, if item1 is not a module (#11183) 2023-12-05 11:38:45 +01:00
signature.rs Replace debug_assert! with assert! in Signature::check_names (#11937) 2024-02-22 16:17:06 -06:00
span.rs Replace panics with errors in thread spawning (#12040) 2024-03-02 11:14:02 -06:00
syntax_shape.rs open, rm, umv, cp, rm and du: Don't globs if inputs are variables or string interpolation (#11886) 2024-02-23 09:17:09 +08:00
ty.rs Glob: don't allow implicit casting between glob and string (#11992) 2024-02-28 23:05:35 +08:00
util.rs Convert more ShellError variants to named fields (#11173) 2023-11-28 06:43:51 -06:00