mirror of
https://github.com/nushell/nushell.git
synced 2024-10-17 07:42:53 +02:00
a8eef9af33
# Description As title, closes: #7921 closes: #8273 # User-Facing Changes when define a closure without pipe, nushell will raise error for now: ``` ❯ let x = {ss ss} Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #2:1:1] 1 │ let x = {ss ss} · ───┬─── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `any`, `each`, `all`, `where` command accepts closure, it forces user input closure like `{||`, or parse error will returned. ``` ❯ {major:2, minor:1, patch:4} | values | each { into string } Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #4:1:1] 1 │ {major:2, minor:1, patch:4} | values | each { into string } · ───────┬─────── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `with-env`, `do`, `def`, `try` are special, they still remain the same, although it says that it accepts a closure, but they don't need to be written like `{||`, it's more likely a block but can capture variable outside of scope: ``` ❯ def test [input] { echo [0 1 2] | do { do { echo $input } } }; test aaa aaa ``` Just realize that It's a big breaking change, we need to update config and scripts... # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
154 lines
3.7 KiB
Rust
154 lines
3.7 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn basic_binary_starts_with() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
"hello world" | into binary | bytes starts-with 0x[68 65 6c 6c 6f]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn basic_string_fails() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
"hello world" | bytes starts-with 0x[68 65 6c 6c 6f]
|
|
"#
|
|
);
|
|
|
|
assert!(actual.err.contains("Input type not supported"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn short_stream_binary() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 5 | bytes starts-with 0x[010101]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn short_stream_mismatch() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[010203]) 5 | bytes starts-with 0x[010204]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "false");
|
|
}
|
|
|
|
#[test]
|
|
fn short_stream_binary_overflow() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 5 | bytes starts-with 0x[010101010101]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "false");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_binary() {
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 32768 | bytes starts-with 0x[010101]
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_binary_overflow() {
|
|
// .. ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01]) 32768 | bytes starts-with (0..32768 | each {|| 0x[01] } | bytes collect)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "false");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_binary_exact() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater (0x[01020304]) 8192 | bytes starts-with (0..<8192 | each {|| 0x[01020304] } | bytes collect)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_string_exact() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
nu --testbin repeater hell 8192 | bytes starts-with (0..<8192 | each {|| "hell" | into binary } | bytes collect)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_mixed_exact() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
let binseg = (0..<2048 | each {|| 0x[003d9fbf] } | bytes collect)
|
|
let strseg = (0..<2048 | each {|| "hell" | into binary } | bytes collect)
|
|
|
|
nu --testbin repeat_bytes 003d9fbf 2048 68656c6c 2048 | bytes starts-with (bytes build $binseg $strseg)
|
|
"#
|
|
);
|
|
|
|
assert_eq!(
|
|
actual.err, "",
|
|
"invocation failed. command line limit likely reached"
|
|
);
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn long_stream_mixed_overflow() {
|
|
// ranges are inclusive..inclusive, so we don't need to +1 to check for an overflow
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
r#"
|
|
let binseg = (0..<2048 | each {|| 0x[003d9fbf] } | bytes collect)
|
|
let strseg = (0..<2048 | each {|| "hell" | into binary } | bytes collect)
|
|
|
|
nu --testbin repeat_bytes 003d9fbf 2048 68656c6c 2048 | bytes starts-with (bytes build $binseg $strseg 0x[01])
|
|
"#
|
|
);
|
|
|
|
assert_eq!(
|
|
actual.err, "",
|
|
"invocation failed. command line limit likely reached"
|
|
);
|
|
assert_eq!(actual.out, "false");
|
|
}
|