mirror of
https://github.com/nushell/nushell.git
synced 2024-10-17 07:42:53 +02:00
cba3e100a0
# Description This PR fixes a bug that occurs if you pass `rename --column` and empty list like `ls | rename -c []`. ## Before ``` > ls | rename -c [] thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', crates\nu-command\src\filters\rename.rs:110:15 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` ## After ``` > ls | rename -c [] Error: nu:🐚:type_mismatch (link) × Type mismatch. ╭─[entry #1:1:1] 1 │ ls | rename -c [] · ─┬ · ╰── The list cannot be empty and must contain only two values: the column's name and its replacement value ╰──── ``` # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
117 lines
3.0 KiB
Rust
117 lines
3.0 KiB
Rust
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn changes_the_column_name() {
|
|
Playground::setup("rename_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_cuatro_mosqueteros.txt",
|
|
r#"
|
|
Andrés N. Robalino
|
|
Jonathan Turner
|
|
Yehuda Katz
|
|
Jason Gedge
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_cuatro_mosqueteros.txt
|
|
| lines
|
|
| wrap name
|
|
| rename mosqueteros
|
|
| get mosqueteros
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "4");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn keeps_remaining_original_names_given_less_new_names_than_total_original_names() {
|
|
Playground::setup("rename_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_cuatro_mosqueteros.txt",
|
|
r#"
|
|
Andrés N. Robalino
|
|
Jonathan Turner
|
|
Yehuda Katz
|
|
Jason Gedge
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_cuatro_mosqueteros.txt
|
|
| lines
|
|
| wrap name
|
|
| default "arepa!" hit
|
|
| rename mosqueteros
|
|
| get hit
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "4");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn errors_if_no_columns_present() {
|
|
Playground::setup("rename_test_3", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_cuatro_mosqueteros.txt",
|
|
r#"
|
|
Andrés N. Robalino
|
|
Jonathan Turner
|
|
Yehuda Katz
|
|
Jason Gedge
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_cuatro_mosqueteros.txt
|
|
| lines
|
|
| rename mosqueteros
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("only record input data is supported"));
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn errors_if_columns_param_is_empty() {
|
|
Playground::setup("rename_test_4", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_cuatro_mosqueteros.txt",
|
|
r#"
|
|
Andrés N. Robalino
|
|
Jonathan Turner
|
|
Yehuda Katz
|
|
Jason Gedge
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_cuatro_mosqueteros.txt
|
|
| lines
|
|
| wrap name
|
|
| default "arepa!" hit
|
|
| rename -c []
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("The column list cannot be empty"));
|
|
})
|
|
}
|