mirror of
https://github.com/nushell/nushell.git
synced 2024-10-16 23:33:49 +02:00
9009f68e09
# Description The message arrow is altered to show the external command name in case it wasn't obvious. (See example for an occasion where it is non-obvious). BEFORE: ``` 〉else if (2mb) > 4mb Error: nu:🐚:external_command (link) × External command failed ╭─[entry #35:1:1] 1 │ else if (2mb) > 4mb · ─┬ · ╰── Cannot convert filesize to a string ╰──── help: All arguments to an external command need to be string-compatible ``` AFTER: ``` 〉else if (2mb) > 4mb Error: nu:🐚:external_command (link) × External command failed ╭─[entry #3:1:1] 1 │ else if (2mb) > 4mb · ─┬ · ╰── Cannot convert filesize to a string argument for 'else' ╰──── help: All arguments to an external command need to be string-compatible ``` # User-Facing Changes See above. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. |
||
|---|---|---|
| .. | ||
| assets | ||
| proptest-regressions/format_conversions | ||
| src | ||
| tests | ||
| build.rs | ||
| Cargo.toml | ||
| LICENSE | ||