mirror of
https://github.com/nushell/nushell.git
synced 2024-12-18 05:02:06 +01:00
91d44f15c1
# Description This allows plugins to report their version (and potentially other metadata in the future). The version is shown in `plugin list` and in `version`. The metadata is stored in the registry file, and reflects whatever was retrieved on `plugin add`, not necessarily the running binary. This can help you to diagnose if there's some kind of mismatch with what you expect. We could potentially use this functionality to show a warning or error if a plugin being run does not have the same version as what was in the cache file, suggesting `plugin add` be run again, but I haven't done that at this point. It is optional, and it requires the plugin author to make some code changes if they want to provide it, since I can't automatically determine the version of the calling crate or anything tricky like that to do it. Example: ``` > plugin list | select name version is_running pid ╭───┬────────────────┬─────────┬────────────┬─────╮ │ # │ name │ version │ is_running │ pid │ ├───┼────────────────┼─────────┼────────────┼─────┤ │ 0 │ example │ 0.93.1 │ false │ │ │ 1 │ gstat │ 0.93.1 │ false │ │ │ 2 │ inc │ 0.93.1 │ false │ │ │ 3 │ python_example │ 0.1.0 │ false │ │ ╰───┴────────────────┴─────────┴────────────┴─────╯ ``` cc @maxim-uvarov (he asked for it) # User-Facing Changes - `plugin list` gets a `version` column - `version` shows plugin versions when available - plugin authors *should* add `fn metadata()` to their `impl Plugin`, but don't have to # Tests + Formatting Tested the low level stuff and also the `plugin list` column. # After Submitting - [ ] update plugin guide docs - [ ] update plugin protocol docs (`Metadata` call & response) - [ ] update plugin template (`fn metadata()` should be easy) - [ ] release notes
93 lines
2.4 KiB
Rust
93 lines
2.4 KiB
Rust
//! Extended from `nu-plugin` examples.
|
|
|
|
use nu_plugin::*;
|
|
use nu_plugin_test_support::PluginTest;
|
|
use nu_protocol::{Example, LabeledError, ShellError, Signature, Type, Value};
|
|
|
|
struct HelloPlugin;
|
|
struct Hello;
|
|
|
|
impl Plugin for HelloPlugin {
|
|
fn version(&self) -> String {
|
|
"0.0.0".into()
|
|
}
|
|
|
|
fn commands(&self) -> Vec<Box<dyn PluginCommand<Plugin = Self>>> {
|
|
vec![Box::new(Hello)]
|
|
}
|
|
}
|
|
|
|
impl SimplePluginCommand for Hello {
|
|
type Plugin = HelloPlugin;
|
|
|
|
fn name(&self) -> &str {
|
|
"hello"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Print a friendly greeting"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build(PluginCommand::name(self)).input_output_type(Type::Nothing, Type::String)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
example: "hello",
|
|
description: "Print a friendly greeting",
|
|
result: Some(Value::test_string("Hello, World!")),
|
|
}]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_plugin: &HelloPlugin,
|
|
_engine: &EngineInterface,
|
|
call: &EvaluatedCall,
|
|
_input: &Value,
|
|
) -> Result<Value, LabeledError> {
|
|
Ok(Value::string("Hello, World!".to_owned(), call.head))
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn test_specified_examples() -> Result<(), ShellError> {
|
|
PluginTest::new("hello", HelloPlugin.into())?.test_command_examples(&Hello)
|
|
}
|
|
|
|
#[test]
|
|
fn test_an_error_causing_example() -> Result<(), ShellError> {
|
|
let result = PluginTest::new("hello", HelloPlugin.into())?.test_examples(&[Example {
|
|
example: "hello --unknown-flag",
|
|
description: "Run hello with an unknown flag",
|
|
result: Some(Value::test_string("Hello, World!")),
|
|
}]);
|
|
assert!(result.is_err());
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn test_an_example_with_the_wrong_result() -> Result<(), ShellError> {
|
|
let result = PluginTest::new("hello", HelloPlugin.into())?.test_examples(&[Example {
|
|
example: "hello",
|
|
description: "Run hello but the example result is wrong",
|
|
result: Some(Value::test_string("Goodbye, World!")),
|
|
}]);
|
|
assert!(result.is_err());
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn test_requiring_nu_cmd_lang_commands() -> Result<(), ShellError> {
|
|
use nu_protocol::Span;
|
|
|
|
let result = PluginTest::new("hello", HelloPlugin.into())?
|
|
.eval("do { let greeting = hello; $greeting }")?
|
|
.into_value(Span::test_data())?;
|
|
|
|
assert_eq!(Value::test_string("Hello, World!"), result);
|
|
|
|
Ok(())
|
|
}
|