mirror of
https://github.com/nushell/nushell.git
synced 2025-08-11 11:14:51 +02:00
.cargo
.github
assets
crates
nu-cli
nu-color-config
nu-command
assets
proptest-regressions
src
tests
commands
assignment
date
hash_
math
move_
network
path
platform
query
random
skip
str_
take
mod.rs
rows.rs
until.rs
while_.rs
url
alias.rs
all.rs
any.rs
append.rs
break_.rs
cal.rs
cd.rs
compact.rs
continue_.rs
cp.rs
def.rs
default.rs
do_.rs
drop.rs
each.rs
echo.rs
empty.rs
enter.rs
error_make.rs
every.rs
export_def.rs
find.rs
first.rs
flatten.rs
for_.rs
format.rs
g.rs
get.rs
glob.rs
group_by.rs
headers.rs
help.rs
histogram.rs
insert.rs
into_filesize.rs
into_int.rs
last.rs
length.rs
let_.rs
lines.rs
loop_.rs
ls.rs
merge.rs
mkdir.rs
mod.rs
mut_.rs
n.rs
nu_check.rs
open.rs
p.rs
parse.rs
prepend.rs
print.rs
range.rs
redirection.rs
reduce.rs
reject.rs
rename.rs
return_.rs
reverse.rs
rm.rs
roll.rs
rotate.rs
run_external.rs
save.rs
select.rs
semicolon.rs
seq.rs
seq_char.rs
shells.rs
sort.rs
sort_by.rs
source_env.rs
split_by.rs
split_column.rs
split_row.rs
table.rs
touch.rs
transpose.rs
try_.rs
uniq.rs
uniq_by.rs
update.rs
upsert.rs
use_.rs
where_.rs
which.rs
while_.rs
with_env.rs
wrap.rs
zip.rs
format_conversions
main.rs
Cargo.toml
LICENSE
build.rs
nu-engine
nu-explore
nu-glob
nu-json
nu-parser
nu-path
nu-plugin
nu-pretty-hex
nu-protocol
nu-system
nu-table
nu-term-grid
nu-test-support
nu-utils
nu_plugin_custom_values
nu_plugin_example
nu_plugin_gstat
nu_plugin_inc
nu_plugin_python
nu_plugin_query
old
README.md
docker
docs
images
pkg_mgrs
src
tests
wix
.gitignore
CODE_OF_CONDUCT.md
CONTRIBUTING.md
Cargo.lock
Cargo.toml
LICENSE
README.md
README.release.txt
build-all-maclin.sh
build-all-windows.cmd
build-all.nu
build.rs
install-all.ps1
install-all.sh
register-plugins.nu
rust-toolchain.toml
uninstall-all.sh
2bacc29d30
# Description This PR changes some commands that previously accepted row conditions (like `$it > 5`) as parameter to accept closures instead. The reasons are: a) The commands would need to move into parser keywords in the future while they feel more like commands to be implemented in Nushell code as a part of standard library. b) In scripts, it is useful to store the predicate condition in a variable which you can't do with row conditions. c) These commands are not used that often to benefit enough from the shorter row condition syntax # User-Facing Changes The following commands now accept **closure** instead of a **row condition**: - `take until` - `take while` - `skip until` - `skip while` - `any` - `all` This is a part of an effort to move away from shape-directed parsing. Related PR: https://github.com/nushell/nushell/pull/7365 # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
52 lines
1.6 KiB
Rust
52 lines
1.6 KiB
Rust
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn condition_is_met() {
|
|
Playground::setup("take_while_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"caballeros.txt",
|
|
r#"
|
|
CHICKEN SUMMARY report date: April 29th, 2020
|
|
--------------------------------------------------------------------
|
|
Chicken Collection,29/04/2020,30/04/2020,31/04/2020
|
|
Yellow Chickens,,,
|
|
Andrés,1,1,1
|
|
Jonathan,1,1,1
|
|
Jason,1,1,1
|
|
Yehuda,1,1,1
|
|
Blue Chickens,,,
|
|
Andrés,1,1,2
|
|
Jonathan,1,1,2
|
|
Jason,1,1,2
|
|
Yehuda,1,1,2
|
|
Red Chickens,,,
|
|
Andrés,1,1,3
|
|
Jonathan,1,1,3
|
|
Jason,1,1,3
|
|
Yehuda,1,1,3
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open --raw caballeros.txt
|
|
| lines
|
|
| skip 2
|
|
| str trim
|
|
| str join (char nl)
|
|
| from csv
|
|
| skip 1
|
|
| take while {|row| $row."Chicken Collection" != "Blue Chickens"}
|
|
| into int "31/04/2020"
|
|
| get "31/04/2020"
|
|
| math sum
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "4");
|
|
})
|
|
}
|