mirror of
https://github.com/nushell/nushell.git
synced 2025-04-10 14:08:40 +02:00
- closes #8523 # Description This PR adds pipeline input support to `generate`. - Without input, `generate` keeps its current behavior. - With input, each invocation of the closure is provided an item from the input stream as pipeline input (`$in`). If/when the input stream runs out, `generate` also stops. Before this PR, there is no filter command that is both stateful _and_ streaming. This PR also refactors `std/iter scan` to use `generate`, making it streaming and more performant over larger inputs. # User-Facing Changes - `generate` now supports pipeline input, passing each element to the closure as `$in` until it runs out - `std/iter scan` is now streaming # Tests + Formatting Added tests to validate the new feature. - 🟢 toolkit fmt - 🟢 toolkit clippy - 🟢 toolkit test - 🟢 toolkit test stdlib # After Submitting N/A
173 lines
3.7 KiB
Rust
173 lines
3.7 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn generate_no_next_break() {
|
|
let actual = nu!(
|
|
"generate {|x| if $x == 3 { {out: $x}} else { {out: $x, next: ($x + 1)} }} 1 | to nuon"
|
|
);
|
|
|
|
assert_eq!(actual.out, "[1, 2, 3]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_null_break() {
|
|
let actual = nu!("generate {|x| if $x <= 3 { {out: $x, next: ($x + 1)} }} 1 | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 2, 3]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_allows_empty_output() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
generate {|x|
|
|
if $x == 1 {
|
|
{next: ($x + 1)}
|
|
} else if $x < 3 {
|
|
{out: $x, next: ($x + 1)}
|
|
}
|
|
} 0 | to nuon
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[0, 2]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_allows_no_output() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
generate {|x|
|
|
if $x < 3 {
|
|
{next: ($x + 1)}
|
|
}
|
|
} 0 | to nuon
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_allows_null_state() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
generate {|x|
|
|
if $x == null {
|
|
{out: "done"}
|
|
} else if $x < 1 {
|
|
{out: "going", next: ($x + 1)}
|
|
} else {
|
|
{out: "stopping", next: null}
|
|
}
|
|
} 0 | to nuon
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[going, stopping, done]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_allows_null_output() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
generate {|x|
|
|
if $x == 3 {
|
|
{out: "done"}
|
|
} else {
|
|
{out: null, next: ($x + 1)}
|
|
}
|
|
} 0 | to nuon
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[null, null, null, done]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_disallows_extra_keys() {
|
|
let actual = nu!("generate {|x| {foo: bar, out: $x}} 0 ");
|
|
assert!(actual.err.contains("Invalid block return"));
|
|
}
|
|
|
|
#[test]
|
|
fn generate_disallows_list() {
|
|
let actual = nu!("generate {|x| [$x, ($x + 1)]} 0 ");
|
|
assert!(actual.err.contains("Invalid block return"));
|
|
}
|
|
|
|
#[test]
|
|
fn generate_disallows_primitive() {
|
|
let actual = nu!("generate {|x| 1} 0");
|
|
assert!(actual.err.contains("Invalid block return"));
|
|
}
|
|
|
|
#[test]
|
|
fn generate_allow_default_parameter() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
generate {|x = 0|
|
|
if $x == 3 {
|
|
{out: "done"}
|
|
} else {
|
|
{out: null, next: ($x + 1)}
|
|
}
|
|
} | to nuon
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[null, null, null, done]");
|
|
|
|
// if initial is given, use initial value
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
generate {|x = 0|
|
|
if $x == 3 {
|
|
{out: "done"}
|
|
} else {
|
|
{out: null, next: ($x + 1)}
|
|
}
|
|
} 1 | to nuon
|
|
"#
|
|
));
|
|
assert_eq!(actual.out, "[null, null, done]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_raise_error_on_no_default_parameter_closure_and_init_val() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
generate {|x|
|
|
if $x == 3 {
|
|
{out: "done"}
|
|
} else {
|
|
{out: null, next: ($x + 1)}
|
|
}
|
|
} | to nuon
|
|
"#
|
|
));
|
|
assert!(actual.err.contains("The initial value is missing"));
|
|
}
|
|
|
|
#[test]
|
|
fn generate_allows_pipeline_input() {
|
|
let actual = nu!(r#"[1 2 3] | generate {|e, x=null| {out: $e, next: null}} | to nuon"#);
|
|
assert_eq!(actual.out, "[1, 2, 3]");
|
|
}
|
|
|
|
#[test]
|
|
fn generate_with_input_is_streaming() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
1..10
|
|
| each {|x| print -en $x; $x}
|
|
| generate {|e, sum=0| let sum = $e + $sum; {out: $sum, next: $sum}}
|
|
| first 5
|
|
| to nuon
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[1, 3, 6, 10, 15]");
|
|
assert_eq!(actual.err, "12345");
|
|
}
|