mirror of
https://github.com/nushell/nushell.git
synced 2024-11-29 03:44:19 +01:00
e1cfc96ee8
# Description There were two problems in `PersistentPlugin` which could cause a deadlock: 1. There were two mutexes being used, and `get()` could potentially hold both simultaneously if it had to spawn. This won't necessarily cause a deadlock on its own, but it does mean that lock order is sensitive 2. `set_gc_config()` called `flush()` while still holding the lock, meaning that the GC thread had to proceed before the lock was released. However, waiting for the GC thread to proceed could mean waiting for the GC thread to call `stop()`, which itself would try to lock the mutex. So, it's not safe to wait for the GC thread while the lock is held. This is fixed now. I've also reverted #12177, as @IanManske reported that this was also happening for him on Linux, and it seems to be this problem which should not be platform-specific at all. I believe this solves it. # User-Facing Changes None # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting |
||
|---|---|---|
| .. | ||
| assets/nu_json | ||
| const_ | ||
| eval | ||
| fixtures | ||
| hooks | ||
| modules | ||
| overlays | ||
| parsing | ||
| path | ||
| plugin_persistence | ||
| plugins | ||
| scope | ||
| shell | ||
| main.rs | ||