mirror of
https://github.com/nushell/nushell.git
synced 2024-11-07 17:14:23 +01:00
f4d9ddd3ad
# Description Attempting to complete a directory with hidden files could cause a variety of issues. When Rust parses the partial path to be completed into components, it removes the trailing `.` since it interprets this to mean "the current directory", but in the case of the completer we actually want to treat the trailling `.` as a literal `.`. This PR fixes this by adding a `.` back into the Path components if the last character of the path is a `.` AND the path is longer than 1 character (eg., not just a ".", since that correctly gets interpreted as Component::CurDir). Here are some things this fixes: - Panic when tab completing for hidden files in a directory with hidden files (ex. `ls test/.`) - Panic when tab completing a directory with only hidden files (since the common prefix ends with a `.`, causing the previous issue) - Mishandling of tab completing hidden files in directory (ex. `ls ~/.<TAB>` lists all files instead of just hidden files) - Trailing `.` being inexplicably removed when tab completing a directory without hidden files While testing for this PR I also noticed there is a similar issue when completing with `..` (ex. `ls ~/test/..<TAB>`) which is not fixed by this PR (edit: see #11922). # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> N/A # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> Added a hidden-files-within-directories test to the `file_completions` test. # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> |
||
|---|---|---|
| .. | ||
| completions | ||
| cp | ||
| eval | ||
| formats | ||
| lsp | ||
| partial_completions | ||
| playground/config | ||
| quoted_completions | ||