nushell/crates/nu-command/src
Reilly Wood 995603b08c
Fix record-to-JSON conversion for HTTP commands (#8663)
This PR fixes a bug introduced in
https://github.com/nushell/nushell/pull/8571.

We were accidentally converting a `Result<Value, ShellError>` to JSON
instead of converting a `Value`. The upshot was that we were sending
JSON like `{"Ok":{"foo":"bar"}}` instead of `{"foo":"bar"}`.

This was an easy bug to miss, because `ureq::send_json()` accepts any
`impl serde::Serialize`. I've added a test to prevent regression.
2023-03-29 11:55:51 -07:00
..
bits Require that values that look like numbers parse as numberlike (#8635) 2023-03-28 19:31:38 +13:00
bytes fix: bytes length example description typo (#8550) 2023-03-21 11:41:37 -05:00
charting fix: fixed typo and improved Value TypeMismatch exceptions (#8324) 2023-03-22 09:47:40 +01:00
conversions Require that values that look like numbers parse as numberlike (#8635) 2023-03-28 19:31:38 +13:00
database Add pattern matching (#8590) 2023-03-24 14:52:01 +13:00
dataframe docs: Use capital letters for CSV and JSON acronyms (#8459) 2023-03-15 21:52:13 -07:00
date Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
debug Require that values that look like numbers parse as numberlike (#8635) 2023-03-28 19:31:38 +13:00
deprecated Revert "Allow NU_LIBS_DIR and friends to be const" (#8501) 2023-03-17 09:33:24 -05:00
env Switch let/let-env family to init with math expressions (#8545) 2023-03-23 09:14:10 +13:00
experimental Uniformize usage() and extra_usage() message ending for commands helper. (#8268) 2023-02-28 21:33:02 -08:00
filesystem Better error message for mv when file not found (#8586) 2023-03-23 11:31:49 -07:00
filters Fix select on empty lists (#8651) 2023-03-28 12:40:29 -07:00
formats Add pattern matching (#8590) 2023-03-24 14:52:01 +13:00
generators Document and critically review ShellError variants - Ep. 2 (#8326) 2023-03-06 11:31:07 +01:00
hash Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
math Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
misc Uniformize usage() and extra_usage() message ending for commands helper. (#8268) 2023-02-28 21:33:02 -08:00
network Fix record-to-JSON conversion for HTTP commands (#8663) 2023-03-29 11:55:51 -07:00
path Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
platform Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
random Document and critically review ShellError variants - Ep. 3 (#8340) 2023-03-06 18:33:09 +01:00
shells Require that values that look like numbers parse as numberlike (#8635) 2023-03-28 19:31:38 +13:00
strings move 'str substring' to only use ranges (#8660) 2023-03-29 20:01:42 +13:00
system When running external command, expand tilde when pass back-quoted word (#8561) 2023-03-26 22:17:51 +13:00
viewers Require that values that look like numbers parse as numberlike (#8635) 2023-03-28 19:31:38 +13:00
default_context.rs Speed up tight loop benchmarks (#8609) 2023-03-26 06:12:57 +13:00
example_test.rs cratification: Example support (#8231) 2023-02-27 13:58:56 -08:00
hook.rs Move variables to var stack (#8604) 2023-03-25 12:56:45 +13:00
input_handler.rs Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
lib.rs feat: add a command_not_found hook (#8314) 2023-03-20 17:05:22 +13:00
progress_bar.rs cp progress bar implementation (#8012) 2023-02-22 11:57:38 -08:00
sort_utils.rs Document and critically review ShellError variants - Ep. 3 (#8340) 2023-03-06 18:33:09 +01:00
util.rs feat: add a command_not_found hook (#8314) 2023-03-20 17:05:22 +13:00