Wind f7d647ac3c open, rm, umv, cp, rm and du: Don't globs if inputs are variables or string interpolation (#11886) ... # Description This is a follow up to https://github.com/nushell/nushell/pull/11621#issuecomment-1937484322 Also Fixes: #11838 ## About the code change It applys the same logic when we pass variables to external commands: 0487e9ffcb/crates/nu-command/src/system/run_external.rs (L162-L170) That is: if user input dynamic things(like variables, sub-expression, or string interpolation), it returns a quoted `NuPath`, then user input won't be globbed # User-Facing Changes Given two input files: `a*c.txt`, `abc.txt` * `let f = "a*c.txt"; rm $f` will remove one file: `a*c.txt`. ~* `let f = "a*c.txt"; rm --glob $f` will remove `a*c.txt` and `abc.txt`~ * `let f: glob = "a*c.txt"; rm $f` will remove `a*c.txt` and `abc.txt` ## Rules about globbing with *variable* Given two files: `a*c.txt`, `abc.txt` | Cmd Type | example | Result | | ----- | ------------------ | ------ | | builtin | let f = "a*c.txt"; rm $f | remove `a*c.txt` | | builtin | let f: glob = "a*c.txt"; rm $f | remove `a*c.txt` and `abc.txt` | builtin | let f = "a*c.txt"; rm ($f \| into glob) | remove `a*c.txt` and `abc.txt` | custom | def crm [f: glob] { rm $f }; let f = "a*c.txt"; crm $f | remove `a*c.txt` and `abc.txt` | custom | def crm [f: glob] { rm ($f \| into string) }; let f = "a*c.txt"; crm $f | remove `a*c.txt` | custom | def crm [f: string] { rm $f }; let f = "a*c.txt"; crm $f | remove `a*c.txt` | custom | def crm [f: string] { rm $f }; let f = "a*c.txt"; crm ($f \| into glob) | remove `a*c.txt` and `abc.txt` In general, if a variable is annotated with `glob` type, nushell will expand glob pattern. Or else, we need to use `into | glob` to expand glob pattern # Tests + Formatting Done # After Submitting I think `str glob-escape` command will be no-longer required. We can remove it.		2024-02-23 09:17:09 +08:00
..
call_ext.rs	make the ansi command const (#11682)	2024-01-30 16:09:43 -06:00
column.rs	Use Record's public API in a bunch of places (#10927)	2023-11-08 14:24:00 +01:00
documentation.rs	Name the Value conversion functions more clearly (#11851)	2024-02-17 18:14:16 +00:00
env.rs	Add Value::coerce_str (#11885)	2024-02-18 17:47:10 +01:00
eval.rs	make stderr works for failed external command (#11914)	2024-02-21 21:15:05 +08:00
glob_from.rs	open, rm, umv, cp, rm and du: Don't globs if inputs are variables or string interpolation (#11886)	2024-02-23 09:17:09 +08:00
lib.rs	Allow operator in constants (#10212)	2023-09-05 16:35:58 +02:00
scope.rs	Remove Record::from_raw_cols_vals_unchecked (#11810)	2024-02-18 14:20:22 +02:00