mirror of
https://github.com/nushell/nushell.git
synced 2024-12-26 00:50:03 +01:00
ce03d8eb12
# Description - Error on negative argument to `last` - Add test for negative value in last Follow-up for #7178 # User-Facing Changes Breaking change: even before #7178 `last` returned an empty `list<any>` when given negative indices. Now this is an [error](https://docs.rs/nu-protocol/latest/nu_protocol/enum.ShellError.html#variant.NeedsPositiveValue) Note: In #7136 we are considering supporting negative indexing # Tests + Formatting + 1 failure test # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
94 lines
1.9 KiB
Rust
94 lines
1.9 KiB
Rust
use nu_test_support::fs::Stub::EmptyFile;
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn gets_the_last_row() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"ls | sort-by name | last 1 | get name.0 | str trim"
|
|
);
|
|
|
|
assert_eq!(actual.out, "utf16.ini");
|
|
}
|
|
|
|
#[test]
|
|
fn gets_last_rows_by_amount() {
|
|
Playground::setup("last_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![
|
|
EmptyFile("los.txt"),
|
|
EmptyFile("tres.txt"),
|
|
EmptyFile("amigos.txt"),
|
|
EmptyFile("arepas.clu"),
|
|
]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
ls
|
|
| last 3
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn gets_last_row_when_no_amount_given() {
|
|
Playground::setup("last_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![EmptyFile("caballeros.txt"), EmptyFile("arepas.clu")]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
ls
|
|
| last
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "1");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn requests_more_rows_than_table_has() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
date | last 50 | length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "1");
|
|
}
|
|
|
|
#[test]
|
|
fn gets_last_row_as_list_when_amount_given() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3]
|
|
| last 1
|
|
| describe
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "list<int>");
|
|
}
|
|
|
|
#[test]
|
|
fn last_errors_on_negative_index() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3]
|
|
| last -2
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("use a positive value"));
|
|
}
|