mirror of
https://github.com/nushell/nushell.git
synced 2024-11-25 09:53:43 +01:00
1c3ff179bc
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Fixes: #13362 This PR fixes the `Display` impl for `CellPath`, as laid out in #13362 and #14090: ```nushell > $.0."0" $.0."0" > $."foo.bar".baz $."foo.bar".baz ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> Cell-paths are now printed using the same `$.` notation that is used to create them, and ambiguous column names are properly quoted. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
284 lines
7.0 KiB
Rust
284 lines
7.0 KiB
Rust
use nu_test_support::fs::Stub::EmptyFile;
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn regular_columns() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
echo [
|
|
[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés Robalino '10/11/2013' A]
|
|
[JT Turner '10/12/2013' B]
|
|
[Yehuda Katz '10/11/2013' A]
|
|
]
|
|
| select rusty_at last_name
|
|
| get 0
|
|
| get last_name
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "Robalino");
|
|
}
|
|
|
|
#[test]
|
|
fn complex_nested_columns() {
|
|
let sample = r#"
|
|
{
|
|
"nu": {
|
|
"committers": [
|
|
{"name": "Andrés N. Robalino"},
|
|
{"name": "JT Turner"},
|
|
{"name": "Yehuda Katz"}
|
|
],
|
|
"releases": [
|
|
{"version": "0.2"}
|
|
{"version": "0.8"},
|
|
{"version": "0.9999999"}
|
|
],
|
|
"0xATYKARNU": [
|
|
["Th", "e", " "],
|
|
["BIG", " ", "UnO"],
|
|
["punto", "cero"]
|
|
]
|
|
}
|
|
}
|
|
"#;
|
|
|
|
let actual = nu!(pipeline(&format!(
|
|
r#"
|
|
{sample}
|
|
| select nu."0xATYKARNU" nu.committers.name nu.releases.version
|
|
| get "nu.releases.version"
|
|
| where $it > "0.8"
|
|
| get 0
|
|
"#
|
|
)));
|
|
|
|
assert_eq!(actual.out, "0.9999999");
|
|
}
|
|
|
|
#[test]
|
|
fn fails_if_given_unknown_column_name() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
echo [
|
|
[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés Robalino '10/11/2013' A]
|
|
[JT Turner '10/12/2013' B]
|
|
[Yehuda Katz '10/11/2013' A]
|
|
]
|
|
| select rrusty_at first_name
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("nu::shell::name_not_found"));
|
|
}
|
|
|
|
#[test]
|
|
fn column_names_with_spaces() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
echo [
|
|
["first name", "last name"];
|
|
|
|
[Andrés Robalino]
|
|
[Andrés Jnth]
|
|
]
|
|
| select "last name"
|
|
| get "last name"
|
|
| str join " "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "Robalino Jnth");
|
|
}
|
|
|
|
#[test]
|
|
fn ignores_duplicate_columns_selected() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
echo [
|
|
["first name", "last name"];
|
|
|
|
[Andrés Robalino]
|
|
[Andrés Jnth]
|
|
]
|
|
| select "first name" "last name" "first name"
|
|
| columns
|
|
| str join " "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "first name last name");
|
|
}
|
|
|
|
#[test]
|
|
fn selects_a_row() {
|
|
Playground::setup("select_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(&[EmptyFile("notes.txt"), EmptyFile("arepas.txt")]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
ls
|
|
| sort-by name
|
|
| select 0
|
|
| get name.0
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "arepas.txt");
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn selects_many_rows() {
|
|
Playground::setup("select_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(&[EmptyFile("notes.txt"), EmptyFile("arepas.txt")]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
ls
|
|
| get name
|
|
| select 1 0
|
|
| length
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "2");
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully1() {
|
|
let actual = nu!("[{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select b? | length");
|
|
|
|
assert_eq!(actual.out, "3".to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully2() {
|
|
let actual = nu!("[{a: 1} {a: 2} {a: 3}] | select b? | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[b]; [null], [null], [null]]".to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully3() {
|
|
let actual = nu!("{foo: bar} | select invalid_key? | to nuon");
|
|
|
|
assert_eq!(actual.out, "{invalid_key: null}".to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully4() {
|
|
let actual = nu!(
|
|
r#""key val\na 1\nb 2\n" | lines | split column --collapse-empty " " | select foo? | to nuon"#
|
|
);
|
|
|
|
assert_eq!(actual.out, r#"[[foo]; [null], [null], [null]]"#.to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_failed1() {
|
|
let actual = nu!("[{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select b ");
|
|
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|
|
|
|
#[test]
|
|
fn select_failed2() {
|
|
let actual = nu!("[{a: 1} {a: 2} {a: 3}] | select b");
|
|
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|
|
|
|
#[test]
|
|
fn select_failed3() {
|
|
let actual =
|
|
nu!(r#""key val\na 1\nb 2\n" | lines | split column --collapse-empty " " | select "100""#);
|
|
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|
|
|
|
#[test]
|
|
fn select_repeated_rows() {
|
|
let actual = nu!("[[a b c]; [1 2 3] [4 5 6] [7 8 9]] | select 0 0 | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a, b, c]; [1, 2, 3]]");
|
|
}
|
|
|
|
#[test]
|
|
fn select_repeated_column() {
|
|
let actual = nu!("[[a b c]; [1 2 3] [4 5 6] [7 8 9]] | select a a | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [1], [4], [7]]");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_errors_works() {
|
|
let actual = nu!(r#"
|
|
let path = "foo";
|
|
[{}] | select -i $path | to nuon
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "[[foo]; [null]]");
|
|
}
|
|
|
|
#[test]
|
|
fn select_on_empty_list_returns_empty_list() {
|
|
// once with a List
|
|
let actual = nu!("[] | select foo | to nuon");
|
|
assert_eq!(actual.out, "[]");
|
|
|
|
// and again with a ListStream
|
|
let actual = nu!("[] | each {|i| $i} | select foo | to nuon");
|
|
assert_eq!(actual.out, "[]");
|
|
}
|
|
|
|
#[test]
|
|
fn select_columns_with_list_spread() {
|
|
let actual = nu!(r#"
|
|
let columns = [a c];
|
|
echo [[a b c]; [1 2 3]] | select ...$columns | to nuon
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "[[a, c]; [1, 3]]");
|
|
}
|
|
|
|
#[test]
|
|
fn select_rows_with_list_spread() {
|
|
let actual = nu!(r#"
|
|
let rows = [0 2];
|
|
echo [[a b c]; [1 2 3] [4 5 6] [7 8 9]] | select ...$rows | to nuon
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "[[a, b, c]; [1, 2, 3], [7, 8, 9]]");
|
|
}
|
|
|
|
#[test]
|
|
fn select_single_row_with_variable() {
|
|
let actual = nu!("let idx = 2; [{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select $idx | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [3]]".to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_with_negative_number_errors_out() {
|
|
let actual = nu!("[1 2 3] | select (-2)");
|
|
assert!(actual.err.contains("negative number"));
|
|
}
|