mirror of
https://github.com/nushell/nushell.git
synced 2024-11-26 02:13:47 +01:00
a6da8ce769
# Description This pr allow us to use `filesize` type as a valid limit value, which is benefit for some file size based limits. # User-Facing Changes ```console /data/source/nushell> ulimit -f ╭───┬─────────────────────────────────────────────────────┬───────────┬───────────╮ │ # │ description │ soft │ hard │ ├───┼─────────────────────────────────────────────────────┼───────────┼───────────┤ │ 0 │ Maximum size of files created by the shell (kB, -f) │ unlimited │ unlimited │ ╰───┴─────────────────────────────────────────────────────┴───────────┴───────────╯ /data/source/nushell> ulimit -f 10Mib /data/source/nushell> ulimit -f ╭───┬─────────────────────────────────────────────────────┬───────┬───────╮ │ # │ description │ soft │ hard │ ├───┼─────────────────────────────────────────────────────┼───────┼───────┤ │ 0 │ Maximum size of files created by the shell (kB, -f) │ 10240 │ 10240 │ ╰───┴─────────────────────────────────────────────────────┴───────┴───────╯ /data/source/nushell> ulimit -n ╭───┬──────────────────────────────────────────────┬──────┬────────╮ │ # │ description │ soft │ hard │ ├───┼──────────────────────────────────────────────┼──────┼────────┤ │ 0 │ Maximum number of open file descriptors (-n) │ 1024 │ 524288 │ ╰───┴──────────────────────────────────────────────┴──────┴────────╯ /data/source/nushell> ulimit -n 10Mib Error: nu:🐚:type_mismatch × Type mismatch. ╭─[entry #5:1:1] 1 │ ulimit -n 10Mib · ─┬─ · ╰── filesize is not compatible with resource RLIMIT_NOFILE ╰──── ``` # Tests + Formatting Make sure you've run and fixed any issues with these commands: - [x] add `commands::ulimit::limit_set_filesize1` - [x] add `commands::ulimit::limit_set_filesize2` - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [x] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - [x] `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - [x] `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library
218 lines
5.5 KiB
Rust
218 lines
5.5 KiB
Rust
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn limit_set_soft1() {
|
|
Playground::setup("limit_set_soft1", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
let soft = (ulimit -s | first | get soft);
|
|
ulimit -s -H $soft;
|
|
let hard = (ulimit -s | first | get hard);
|
|
$soft == $hard
|
|
"
|
|
));
|
|
|
|
assert!(actual.out.contains("true"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_soft2() {
|
|
Playground::setup("limit_set_soft2", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
let soft = (ulimit -s | first | get soft);
|
|
ulimit -s -H soft;
|
|
let hard = (ulimit -s | first | get hard);
|
|
$soft == $hard
|
|
"
|
|
));
|
|
|
|
assert!(actual.out.contains("true"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_hard1() {
|
|
Playground::setup("limit_set_hard1", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
let hard = (ulimit -s | first | get hard);
|
|
ulimit -s $hard;
|
|
let soft = (ulimit -s | first | get soft);
|
|
$soft == $hard
|
|
"
|
|
));
|
|
|
|
assert!(actual.out.contains("true"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_hard2() {
|
|
Playground::setup("limit_set_hard2", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
let hard = (ulimit -s | first | get hard);
|
|
ulimit -s hard;
|
|
let soft = (ulimit -s | first | get soft);
|
|
$soft == $hard
|
|
"
|
|
));
|
|
|
|
assert!(actual.out.contains("true"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_invalid1() {
|
|
Playground::setup("limit_set_invalid1", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
let hard = (ulimit -s | first | get hard);
|
|
match $hard {
|
|
\"unlimited\" => { echo \"unlimited\" },
|
|
$x => {
|
|
let new = $x + 1;
|
|
ulimit -s $new
|
|
}
|
|
}
|
|
"
|
|
));
|
|
|
|
assert!(
|
|
actual.out.contains("unlimited")
|
|
|| actual.err.contains("EPERM: Operation not permitted")
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_invalid2() {
|
|
Playground::setup("limit_set_invalid2", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(),
|
|
"
|
|
let val = -100;
|
|
ulimit -c $val
|
|
"
|
|
);
|
|
|
|
assert!(actual.err.contains("can't convert i64 to rlim_t"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_invalid3() {
|
|
Playground::setup("limit_set_invalid3", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(),
|
|
"
|
|
ulimit -c abcd
|
|
"
|
|
);
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("Only unlimited, soft and hard are supported for strings"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_invalid4() {
|
|
Playground::setup("limit_set_invalid4", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(),
|
|
"
|
|
ulimit -c 100.0
|
|
"
|
|
);
|
|
|
|
assert!(actual.err.contains("string, int or filesize required"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_invalid5() {
|
|
use nix::sys::resource::rlim_t;
|
|
|
|
let max = (rlim_t::MAX / 1024) + 1;
|
|
|
|
Playground::setup("limit_set_invalid5", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
format!(
|
|
"
|
|
let hard = (ulimit -c | first | get hard);
|
|
match $hard {{
|
|
\"unlimited\" => {{
|
|
ulimit -c -S 0;
|
|
ulimit -c {max};
|
|
ulimit -c
|
|
| first
|
|
| get soft
|
|
}},
|
|
_ => {{
|
|
echo \"unlimited\"
|
|
}}
|
|
}}
|
|
").as_str()
|
|
));
|
|
|
|
assert!(actual.out.eq("unlimited"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_filesize1() {
|
|
Playground::setup("limit_set_filesize1", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
let hard = (ulimit -c | first | get hard);
|
|
match $hard {
|
|
\"unlimited\" => {
|
|
ulimit -c 1Mib;
|
|
ulimit -c
|
|
| first
|
|
| get soft
|
|
},
|
|
$x if $x >= 1024 * 1024 => {
|
|
ulimit -c 1Mib;
|
|
ulimit -c
|
|
| first
|
|
| get soft
|
|
}
|
|
_ => {
|
|
echo \"hard limit too small\"
|
|
}
|
|
}
|
|
"
|
|
));
|
|
|
|
assert!(actual.out.eq("1024") || actual.out.eq("hard limit too small"));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn limit_set_filesize2() {
|
|
Playground::setup("limit_set_filesize2", |dirs, _sandbox| {
|
|
let actual = nu!(
|
|
cwd: dirs.test(),
|
|
"
|
|
ulimit -n 10Kib
|
|
"
|
|
);
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("filesize is not compatible with resource RLIMIT_NOFILE"));
|
|
});
|
|
}
|