mirror of
https://github.com/nushell/nushell.git
synced 2024-11-26 02:13:47 +01:00
df15fc24fe
# Description
I have (hopefully) simplified the `log.nu` internal structure and added
customizable log format for all `log` commands
# User-Facing Changes
- [x] Replaced constants with env records for:
- ansi (newly added)
- log level
- prefix
- short prefix
- [x] Added `format` argument to all log commands
- [x] Assertions for (not) equality (equal, not equal, greater,
lesser...) now put left and right values inside `'` quotes, so the
assertions for strings are more meaningful
- [x] Documented the %-formatting of log messages
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the
standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
---------
Co-authored-by: amtoine <stevan.antoine@gmail.com>
37 lines
1.2 KiB
Plaintext
37 lines
1.2 KiB
Plaintext
use std *
|
|
|
|
export def "test_env_log_ansi" [] {
|
|
assert equal $env.LOG_ANSI.CRITICAL (ansi red_bold)
|
|
assert equal $env.LOG_ANSI.ERROR (ansi red)
|
|
assert equal $env.LOG_ANSI.WARNING (ansi yellow)
|
|
assert equal $env.LOG_ANSI.INFO (ansi default)
|
|
assert equal $env.LOG_ANSI.DEBUG (ansi default_dimmed)
|
|
}
|
|
|
|
export def "test_env_log_level" [] {
|
|
assert equal $env.LOG_LEVEL.CRITICAL 50
|
|
assert equal $env.LOG_LEVEL.ERROR 40
|
|
assert equal $env.LOG_LEVEL.WARNING 30
|
|
assert equal $env.LOG_LEVEL.INFO 20
|
|
assert equal $env.LOG_LEVEL.DEBUG 10
|
|
}
|
|
|
|
export def "test_env_log_prefix" [] {
|
|
assert equal $env.LOG_PREFIX.CRITICAL "CRT"
|
|
assert equal $env.LOG_PREFIX.ERROR "ERR"
|
|
assert equal $env.LOG_PREFIX.WARNING "WRN"
|
|
assert equal $env.LOG_PREFIX.INFO "INF"
|
|
assert equal $env.LOG_PREFIX.DEBUG "DBG"
|
|
}
|
|
|
|
export def "test_env_log_short_prefix" [] {
|
|
assert equal $env.LOG_SHORT_PREFIX.CRITICAL "C"
|
|
assert equal $env.LOG_SHORT_PREFIX.ERROR "E"
|
|
assert equal $env.LOG_SHORT_PREFIX.WARNING "W"
|
|
assert equal $env.LOG_SHORT_PREFIX.INFO "I"
|
|
assert equal $env.LOG_SHORT_PREFIX.DEBUG "D"
|
|
}
|
|
|
|
export def "test_env_log_format" [] {
|
|
assert equal $env.LOG_FORMAT $"%ANSI_START%%DATE%|%LEVEL%|(ansi u)%MSG%%ANSI_STOP%"
|
|
} |