mirror of
https://github.com/nushell/nushell.git
synced 2024-10-17 07:42:53 +02:00
a8eef9af33
# Description As title, closes: #7921 closes: #8273 # User-Facing Changes when define a closure without pipe, nushell will raise error for now: ``` ❯ let x = {ss ss} Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #2:1:1] 1 │ let x = {ss ss} · ───┬─── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `any`, `each`, `all`, `where` command accepts closure, it forces user input closure like `{||`, or parse error will returned. ``` ❯ {major:2, minor:1, patch:4} | values | each { into string } Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #4:1:1] 1 │ {major:2, minor:1, patch:4} | values | each { into string } · ───────┬─────── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `with-env`, `do`, `def`, `try` are special, they still remain the same, although it says that it accepts a closure, but they don't need to be written like `{||`, it's more likely a block but can capture variable outside of scope: ``` ❯ def test [input] { echo [0 1 2] | do { do { echo $input } } }; test aaa aaa ``` Just realize that It's a big breaking change, we need to update config and scripts... # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
133 lines
3.0 KiB
Rust
133 lines
3.0 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn checks_all_rows_are_true() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
echo [ "Andrés", "Andrés", "Andrés" ]
|
|
| all {|it| $it == "Andrés" }
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn checks_all_rows_are_false_with_param() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3, 4] | all { |a| $a >= 5 }
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "false");
|
|
}
|
|
|
|
#[test]
|
|
fn checks_all_rows_are_true_with_param() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[1, 2, 3, 4] | all { |a| $a < 5 }
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn checks_all_columns_of_a_table_is_true() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
[ first_name, last_name, rusty_at, likes ];
|
|
[ Andrés, Robalino, 10/11/2013, 1 ]
|
|
[ JT, Turner, 10/12/2013, 1 ]
|
|
[ Darren, Schroeder, 10/11/2013, 1 ]
|
|
[ Yehuda, Katz, 10/11/2013, 1 ]
|
|
]
|
|
| all {|x| $x.likes > 0 }
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn checks_if_all_returns_error_with_invalid_command() {
|
|
// Using `with-env` to remove `st` possibly being an external program
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
with-env {PATH: ""} {
|
|
[red orange yellow green blue purple] | all {|it| ($it | st length) > 4 }
|
|
}
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("can't run executable") || actual.err.contains("did you mean"));
|
|
}
|
|
|
|
#[test]
|
|
fn works_with_1_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | all {|e| print $e | true }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "123true");
|
|
}
|
|
|
|
#[test]
|
|
fn works_with_0_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | all {|| print $in | true }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "123true");
|
|
}
|
|
|
|
#[test]
|
|
fn early_exits_with_1_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | all {|e| print $e | false }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "1false");
|
|
}
|
|
|
|
#[test]
|
|
fn early_exits_with_0_param_blocks() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1 2 3] | all {|| print $in | false }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "1false");
|
|
}
|
|
|
|
#[test]
|
|
fn all_uses_enumerate_index() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[7 8 9] | enumerate | all {|el| print $el.index | true }"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "012true");
|
|
}
|
|
|
|
#[test]
|
|
fn unique_env_each_iteration() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats",
|
|
"[1 2] | all {|| print ($env.PWD | str ends-with 'formats') | cd '/' | true } | to nuon"
|
|
);
|
|
|
|
assert_eq!(actual.out, "truetruetrue");
|
|
}
|