mirror of
https://github.com/nushell/nushell.git
synced 2025-01-12 17:28:13 +01:00
99076af18b
# Description _(Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes.)_ I opened this PR to unify the run command method. It's mainly to improve consistency across the tree. # User-Facing Changes None. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
116 lines
3.4 KiB
Rust
116 lines
3.4 KiB
Rust
use crate::math::utils::run_with_function;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{Category, Example, PipelineData, ShellError, Signature, Span, Type, Value};
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"math variance"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("math variance")
|
|
.input_output_types(vec![(Type::List(Box::new(Type::Number)), Type::Number)])
|
|
.switch(
|
|
"sample",
|
|
"calculate sample variance (i.e. using N-1 as the denominator)",
|
|
Some('s'),
|
|
)
|
|
.category(Category::Math)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Returns the variance of a list of numbers or of each column in a table"
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["deviation", "dispersion", "variation", "statistics"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let sample = call.has_flag("sample");
|
|
run_with_function(call, input, compute_variance(sample))
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Get the variance of a list of numbers",
|
|
example: "[1 2 3 4 5] | math variance",
|
|
result: Some(Value::test_float(2.0)),
|
|
},
|
|
Example {
|
|
description: "Get the sample variance of a list of numbers",
|
|
example: "[1 2 3 4 5] | math variance -s",
|
|
result: Some(Value::test_float(2.5)),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
fn sum_of_squares(values: &[Value], span: &Span) -> Result<Value, ShellError> {
|
|
let n = Value::int(values.len() as i64, *span);
|
|
let mut sum_x = Value::int(0, *span);
|
|
let mut sum_x2 = Value::int(0, *span);
|
|
for value in values {
|
|
let v = match &value {
|
|
Value::Int { .. } | Value::Float { .. } => Ok(value),
|
|
Value::Error { error } => Err(error.clone()),
|
|
_ => Err(ShellError::UnsupportedInput(
|
|
"Attempted to compute the sum of squares of a non-integer, non-float value"
|
|
.to_string(),
|
|
"value originates from here".into(),
|
|
*span,
|
|
value.expect_span(),
|
|
)),
|
|
}?;
|
|
let v_squared = &v.mul(*span, v, *span)?;
|
|
sum_x2 = sum_x2.add(*span, v_squared, *span)?;
|
|
sum_x = sum_x.add(*span, v, *span)?;
|
|
}
|
|
|
|
let sum_x_squared = sum_x.mul(*span, &sum_x, *span)?;
|
|
let sum_x_squared_div_n = sum_x_squared.div(*span, &n, *span)?;
|
|
|
|
let ss = sum_x2.sub(*span, &sum_x_squared_div_n, *span)?;
|
|
|
|
Ok(ss)
|
|
}
|
|
|
|
pub fn compute_variance(
|
|
sample: bool,
|
|
) -> impl Fn(&[Value], Span, &Span) -> Result<Value, ShellError> {
|
|
move |values: &[Value], span: Span, head: &Span| {
|
|
let n = if sample {
|
|
values.len() - 1
|
|
} else {
|
|
values.len()
|
|
};
|
|
// sum_of_squares() needs the span of the original value, not the call head.
|
|
let ss = sum_of_squares(values, &span)?;
|
|
let n = Value::int(n as i64, *head);
|
|
ss.div(*head, &n, *head)
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|