mirror of
https://github.com/nushell/nushell.git
synced 2024-12-23 15:39:06 +01:00
399a7c8836
# Description This PR introduces a new `Signals` struct to replace our adhoc passing around of `ctrlc: Option<Arc<AtomicBool>>`. Doing so has a few benefits: - We can better enforce when/where resetting or triggering an interrupt is allowed. - Consolidates `nu_utils::ctrl_c::was_pressed` and other ad-hoc re-implementations into a single place: `Signals::check`. - This allows us to add other types of signals later if we want. E.g., exiting or suspension. - Similarly, we can more easily change the underlying implementation if we need to in the future. - Places that used to have a `ctrlc` of `None` now use `Signals::empty()`, so we can double check these usages for correctness in the future. |
||
---|---|---|
.. | ||
assets | ||
src | ||
tests | ||
Cargo.toml | ||
LICENSE | ||
README.md |
nu-cmd-extra
The commands in this crate are the extra commands of Nushell. These commands are not in a state to be guaranteed to be part of the 1.0 API; meaning that there is no guarantee longer term that these commands will be around into the future.
For a while we did exclude them behind the --features extra
compile time
flag, meaning that the default release did not contain them. As we (the Nushell
team) shipped a full build including both extra
and dataframe
for some
time, we chose to sunset the extra
feature but keep the commands in this
crate for now. In the future the commands may be moved to more topical crates
or discarded into plugins.