mirror of
https://github.com/nushell/nushell.git
synced 2025-07-14 05:15:23 +02:00
# Description This doesn't really do much that the user could see, but it helps get us ready to do the steps of the refactor to split the span off of Value, so that values can be spanless. This allows us to have top-level values that can hold both a Value and a Span, without requiring that all values have them. We expect to see significant memory reduction by removing so many unnecessary spans from values. For example, a table of 100,000 rows and 5 columns would have a savings of ~8megs in just spans that are almost always duplicated. # User-Facing Changes Nothing yet # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
136 lines
3.8 KiB
Rust
136 lines
3.8 KiB
Rust
use nu_cmd_base::input_handler::{operate, CmdArgument};
|
|
use nu_engine::CallExt;
|
|
use nu_protocol::ast::{Call, CellPath};
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
format_filesize, Category, Example, PipelineData, ShellError, Signature, Span, SyntaxShape,
|
|
Type, Value,
|
|
};
|
|
|
|
struct Arguments {
|
|
format_value: String,
|
|
cell_paths: Option<Vec<CellPath>>,
|
|
}
|
|
|
|
impl CmdArgument for Arguments {
|
|
fn take_cell_paths(&mut self) -> Option<Vec<CellPath>> {
|
|
self.cell_paths.take()
|
|
}
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
pub struct FormatFilesize;
|
|
|
|
impl Command for FormatFilesize {
|
|
fn name(&self) -> &str {
|
|
"format filesize"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("format filesize")
|
|
.input_output_types(vec![
|
|
(Type::Filesize, Type::String),
|
|
(Type::Table(vec![]), Type::Table(vec![])),
|
|
(Type::Record(vec![]), Type::Record(vec![])),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.required(
|
|
"format value",
|
|
SyntaxShape::String,
|
|
"the format into which convert the file sizes",
|
|
)
|
|
.rest(
|
|
"rest",
|
|
SyntaxShape::CellPath,
|
|
"For a data structure input, format filesizes at the given cell paths",
|
|
)
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Converts a column of filesizes to some specified format."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["convert", "display", "pattern", "human readable"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let format_value = call
|
|
.req::<Value>(engine_state, stack, 0)?
|
|
.as_string()?
|
|
.to_ascii_lowercase();
|
|
let cell_paths: Vec<CellPath> = call.rest(engine_state, stack, 1)?;
|
|
let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
|
|
let arg = Arguments {
|
|
format_value,
|
|
cell_paths,
|
|
};
|
|
operate(
|
|
format_value_impl,
|
|
arg,
|
|
input,
|
|
call.head,
|
|
engine_state.ctrlc.clone(),
|
|
)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Convert the size column to KB",
|
|
example: "ls | format filesize KB size",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Convert the apparent column to B",
|
|
example: "du | format filesize B apparent",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Convert the size data to MB",
|
|
example: "4Gb | format filesize MB",
|
|
result: Some(Value::test_string("4000.0 MB")),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
fn format_value_impl(val: &Value, arg: &Arguments, span: Span) -> Value {
|
|
match val {
|
|
Value::Filesize { val, span } => Value::String {
|
|
// don't need to concern about metric, we just format units by what user input.
|
|
val: format_filesize(*val, &arg.format_value, None),
|
|
span: *span,
|
|
},
|
|
Value::Error { .. } => val.clone(),
|
|
_ => Value::Error {
|
|
error: Box::new(ShellError::OnlySupportsThisInputType {
|
|
exp_input_type: "filesize".into(),
|
|
wrong_type: val.get_type().to_string(),
|
|
dst_span: span,
|
|
src_span: val.span(),
|
|
}),
|
|
span,
|
|
},
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(FormatFilesize)
|
|
}
|
|
}
|