nushell/crates/nu-command/tests/commands/network/port.rs
nibon7 b227eea668
Add checks for ports (#11214)
# Description
This PR adds checks for ports. This fixes unexpected output similar to
the one in the comment
https://github.com/nushell/nushell/pull/11210#issuecomment-1837152357.

* before

```console
/data/source/nushell> port 65536 99999                                                                                        
41233
```

* after

```console
/data/source/nushell> port 65536 99999                                                                                             
Error: nu:🐚:cant_convert

  × Can't convert to u16.
   ╭─[entry #1:1:1]
 1 │ port 65536 99999
   ·      ──┬──
   ·        ╰── can't convert usize to u16
   ╰────
  help: out of range integral type conversion attempted (min: 0, max: 65535)
```

# User-Facing Changes
N/A

# Tests + Formatting
* [x] add `port_out_of_range` test

# After Submitting
N/A
2023-12-03 08:07:15 -06:00

57 lines
1.6 KiB
Rust

use nu_test_support::{nu, pipeline};
use std::net::TcpListener;
use std::sync::mpsc;
#[test]
fn port_with_invalid_range() {
let actual = nu!("port 4000 3999");
assert!(actual.err.contains("Invalid range"))
}
#[test]
fn port_with_already_usage() {
let retry_times = 10;
for _ in 0..retry_times {
let (tx, rx) = mpsc::sync_channel(0);
// let system pick a free port for us.
let free_port = {
let listener = TcpListener::bind("127.0.0.1:0").expect("failed to pick a port");
listener.local_addr().unwrap().port()
};
let handler = std::thread::spawn(move || {
let _listener = TcpListener::bind(format!("127.0.0.1:{free_port}"));
let _ = rx.recv();
});
let actual = nu!(pipeline(&format!("port {free_port} {free_port}")));
let _ = tx.send(true);
// make sure that the thread is closed and we release the port.
handler.join().unwrap();
// check for error kind str.
if actual
.err
.contains("Every port has been tried, but no valid one was found")
{
return;
}
}
panic!("already check port report AddrInUse for several times, but still failed.");
}
#[test]
fn port_from_system_given() {
let actual = nu!("port");
// check that we can get an integer port from system.
assert!(actual.out.parse::<u16>().unwrap() > 0)
}
#[test]
fn port_out_of_range() {
let actual = nu!("port 65536 99999");
assert!(actual.err.contains("can't convert usize to u16"));
}