mirror of
https://github.com/nushell/nushell.git
synced 2025-04-16 09:18:21 +02:00
b662c2eb96
# Description As title, when execute external sub command, auto-trimming end new-lines, like how fish shell does. And if the command is executed directly like: `cat tmp`, the result won't change. Fixes: #6816 Fixes: #3980 Note that although nushell works correctly by directly replace output of external command to variable(or other places like string interpolation), it's not friendly to user, and users almost want to use `str trim` to trim trailing newline, I think that's why fish shell do this automatically. If the pr is ok, as a result, no more `str trim -r` is required when user is writing scripts which using external commands. # User-Facing Changes Before: <img width="523" alt="img" src="https://user-images.githubusercontent.com/22256154/202468810-86b04dbb-c147-459a-96a5-e0095eeaab3d.png"> After: <img width="505" alt="img" src="https://user-images.githubusercontent.com/22256154/202468599-7b537488-3d6b-458e-9d75-d85780826db0.png"> # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace --features=extra` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. |
||
|---|---|---|
| .. | ||
| overlay | ||
| alias.rs | ||
| ast.rs | ||
| commandline.rs | ||
| debug.rs | ||
| def_env.rs | ||
| def.rs | ||
| describe.rs | ||
| do_.rs | ||
| echo.rs | ||
| error_make.rs | ||
| export_alias.rs | ||
| export_def_env.rs | ||
| export_def.rs | ||
| export_extern.rs | ||
| export_use.rs | ||
| export.rs | ||
| extern_.rs | ||
| for_.rs | ||
| help.rs | ||
| hide_env.rs | ||
| hide.rs | ||
| if_.rs | ||
| ignore.rs | ||
| let_.rs | ||
| metadata.rs | ||
| mod.rs | ||
| module.rs | ||
| mut_.rs | ||
| register.rs | ||
| use_.rs | ||
| version.rs | ||
| while_.rs | ||
