mirror of
https://github.com/nushell/nushell.git
synced 2024-11-25 18:03:51 +01:00
f8c82588b6
# Description This PR adds an explicit indication for duplicate flags, which helps with debugging. # User-Facing Changes N/A # Tests + Formatting - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [x] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - [x] `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - [x] `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library # After Submitting N/A
173 lines
5.5 KiB
Rust
173 lines
5.5 KiB
Rust
use nu_protocol::{Flag, PositionalArg, Signature, SyntaxShape};
|
|
|
|
#[test]
|
|
fn test_signature() {
|
|
let signature = Signature::new("new_signature");
|
|
let from_build = Signature::build("new_signature");
|
|
|
|
// asserting partial eq implementation
|
|
assert_eq!(signature, from_build);
|
|
|
|
// constructing signature with description
|
|
let signature = Signature::new("signature").usage("example usage");
|
|
assert_eq!(signature.usage, "example usage".to_string())
|
|
}
|
|
|
|
#[test]
|
|
fn test_signature_chained() {
|
|
let signature = Signature::new("new_signature")
|
|
.usage("description")
|
|
.required("required", SyntaxShape::String, "required description")
|
|
.optional("optional", SyntaxShape::String, "optional description")
|
|
.required_named(
|
|
"req-named",
|
|
SyntaxShape::String,
|
|
"required named description",
|
|
Some('r'),
|
|
)
|
|
.named("named", SyntaxShape::String, "named description", Some('n'))
|
|
.switch("switch", "switch description", None)
|
|
.rest("rest", SyntaxShape::String, "rest description");
|
|
|
|
assert_eq!(signature.required_positional.len(), 1);
|
|
assert_eq!(signature.optional_positional.len(), 1);
|
|
assert_eq!(signature.named.len(), 3);
|
|
assert!(signature.rest_positional.is_some());
|
|
assert_eq!(signature.get_shorts(), vec!['r', 'n']);
|
|
assert_eq!(signature.get_names(), vec!["req-named", "named", "switch"]);
|
|
assert_eq!(signature.num_positionals(), 2);
|
|
|
|
assert_eq!(
|
|
signature.get_positional(0),
|
|
Some(PositionalArg {
|
|
name: "required".to_string(),
|
|
desc: "required description".to_string(),
|
|
shape: SyntaxShape::String,
|
|
var_id: None,
|
|
default_value: None,
|
|
})
|
|
);
|
|
assert_eq!(
|
|
signature.get_positional(1),
|
|
Some(PositionalArg {
|
|
name: "optional".to_string(),
|
|
desc: "optional description".to_string(),
|
|
shape: SyntaxShape::String,
|
|
var_id: None,
|
|
default_value: None,
|
|
})
|
|
);
|
|
assert_eq!(
|
|
signature.get_positional(2),
|
|
Some(PositionalArg {
|
|
name: "rest".to_string(),
|
|
desc: "rest description".to_string(),
|
|
shape: SyntaxShape::String,
|
|
var_id: None,
|
|
default_value: None,
|
|
})
|
|
);
|
|
|
|
assert_eq!(
|
|
signature.get_long_flag("req-named"),
|
|
Some(Flag {
|
|
long: "req-named".to_string(),
|
|
short: Some('r'),
|
|
arg: Some(SyntaxShape::String),
|
|
required: true,
|
|
desc: "required named description".to_string(),
|
|
var_id: None,
|
|
default_value: None,
|
|
})
|
|
);
|
|
|
|
assert_eq!(
|
|
signature.get_short_flag('r'),
|
|
Some(Flag {
|
|
long: "req-named".to_string(),
|
|
short: Some('r'),
|
|
arg: Some(SyntaxShape::String),
|
|
required: true,
|
|
desc: "required named description".to_string(),
|
|
var_id: None,
|
|
default_value: None,
|
|
})
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
#[should_panic(expected = "There may be duplicate short flags for '-n'")]
|
|
fn test_signature_same_short() {
|
|
// Creating signature with same short name should panic
|
|
Signature::new("new_signature")
|
|
.required_named(
|
|
"required-named",
|
|
SyntaxShape::String,
|
|
"required named description",
|
|
Some('n'),
|
|
)
|
|
.named("named", SyntaxShape::String, "named description", Some('n'));
|
|
}
|
|
|
|
#[test]
|
|
#[should_panic(expected = "There may be duplicate name flags for '--name'")]
|
|
fn test_signature_same_name() {
|
|
// Creating signature with same short name should panic
|
|
Signature::new("new-signature")
|
|
.required_named(
|
|
"name",
|
|
SyntaxShape::String,
|
|
"required named description",
|
|
Some('r'),
|
|
)
|
|
.named("name", SyntaxShape::String, "named description", Some('n'));
|
|
}
|
|
|
|
#[test]
|
|
fn test_signature_round_trip() {
|
|
let signature = Signature::new("new_signature")
|
|
.usage("description")
|
|
.required("first", SyntaxShape::String, "first required")
|
|
.required("second", SyntaxShape::Int, "second required")
|
|
.optional("optional", SyntaxShape::String, "optional description")
|
|
.required_named(
|
|
"req-named",
|
|
SyntaxShape::String,
|
|
"required named description",
|
|
Some('r'),
|
|
)
|
|
.named("named", SyntaxShape::String, "named description", Some('n'))
|
|
.switch("switch", "switch description", None)
|
|
.rest("rest", SyntaxShape::String, "rest description")
|
|
.category(nu_protocol::Category::Conversions);
|
|
|
|
let string = serde_json::to_string_pretty(&signature).unwrap();
|
|
let returned: Signature = serde_json::from_str(&string).unwrap();
|
|
|
|
assert_eq!(signature.name, returned.name);
|
|
assert_eq!(signature.usage, returned.usage);
|
|
assert_eq!(signature.extra_usage, returned.extra_usage);
|
|
assert_eq!(signature.is_filter, returned.is_filter);
|
|
assert_eq!(signature.category, returned.category);
|
|
|
|
signature
|
|
.required_positional
|
|
.iter()
|
|
.zip(returned.required_positional.iter())
|
|
.for_each(|(lhs, rhs)| assert_eq!(lhs, rhs));
|
|
|
|
signature
|
|
.optional_positional
|
|
.iter()
|
|
.zip(returned.optional_positional.iter())
|
|
.for_each(|(lhs, rhs)| assert_eq!(lhs, rhs));
|
|
|
|
signature
|
|
.named
|
|
.iter()
|
|
.zip(returned.named.iter())
|
|
.for_each(|(lhs, rhs)| assert_eq!(lhs, rhs));
|
|
|
|
assert_eq!(signature.rest_positional, returned.rest_positional,);
|
|
}
|