mirror of https://github.com/nushell/nushell.git synced 2024-11-22 08:23:24 +01:00

History

Jakub Žádník b8d37a7541 Fix panic in `rotate`; Add safe record creation function (#11718 ) <!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [linking keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. Provide examples and/or screenshots if your changes affect the user experience. --> Fixes https://github.com/nushell/nushell/issues/11716 The problem is in our [record creation API](`0d518bf813/crates/nu-protocol/src/value/record.rs (L33)`) which panics if the numbers of columns and values are different. I added a safe variant that returns a `Result` and used it in the `rotate` command. ## TODO in another PR: Go through all `from_raw_cols_vals_unchecked()` (this includes the `record!` macro which uses the unchecked version) and make sure that either a) it is guaranteed the number of cols and vals is the same, or b) convert the call to `from_raw_cols_vals()` Reason: Nushell should never panic. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > Note > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->		2024-02-03 13:23:16 +02:00
..
nu_plugin_custom_values	Allow plugins to receive configuration from the nushell configuration (#10955 )	2024-01-15 16:59:47 +08:00
nu_plugin_example	Fix panic in `rotate`; Add safe record creation function (#11718 )	2024-02-03 13:23:16 +02:00
nu_plugin_formats	Bump ical from 0.9.0 to 0.10.0 (#11661 )	2024-01-29 09:34:06 +08:00
nu_plugin_gstat	Allow plugins to receive configuration from the nushell configuration (#10955 )	2024-01-15 16:59:47 +08:00
nu_plugin_inc	Plugin explicit flags (#11581 )	2024-01-22 15:00:43 -06:00
nu_plugin_python	remove `vectorize_over_list` from python plugin (#9905 )	2023-08-03 16:46:48 +02:00
nu_plugin_query	`query web --query` should return `list<list<string>>` like the scraper crate's `ElementRef::text()` (#11705 )	2024-02-02 19:40:47 -06:00
nu-cli	Tidy up the REPL main loop (#11655 )	2024-01-31 09:32:19 -08:00
nu-cmd-base	Unify glob behavior on `open`, `rm`, `cp-old`, `mv`, `umv`, `cp` and `du` commands (#11621 )	2024-01-26 21:57:35 +08:00
nu-cmd-dataframe	Fix panic in `rotate`; Add safe record creation function (#11718 )	2024-02-03 13:23:16 +02:00
nu-cmd-extra	Fix panic in `rotate`; Add safe record creation function (#11718 )	2024-02-03 13:23:16 +02:00
nu-cmd-lang	update nu-ansi-term to 0.50, lscolors to 0.17, and add the Style attribute to Suggestion (#11635 )	2024-01-24 20:57:15 -08:00
nu-color-config	update nu-ansi-term to 0.50, lscolors to 0.17, and add the Style attribute to Suggestion (#11635 )	2024-01-24 20:57:15 -08:00
nu-command	Fix panic in `rotate`; Add safe record creation function (#11718 )	2024-02-03 13:23:16 +02:00
nu-engine	Fix panic in `rotate`; Add safe record creation function (#11718 )	2024-02-03 13:23:16 +02:00
nu-explore	Fix panic in `rotate`; Add safe record creation function (#11718 )	2024-02-03 13:23:16 +02:00
nu-glob	Bump to dev version 0.89.1 (#11513 )	2024-01-11 00:19:21 +13:00
nu-json	Refactor `lines` command (#11685 )	2024-01-30 15:56:19 -06:00
nu-lsp	Fix "Char index out of bounds" Error (#11526 )	2024-01-11 15:24:49 -06:00
nu-parser	Tighten def body parsing (#11719 )	2024-02-03 13:20:40 +02:00
nu-path	Bump to dev version 0.89.1 (#11513 )	2024-01-11 00:19:21 +13:00
nu-plugin	Plugin explicit flags (#11581 )	2024-01-22 15:00:43 -06:00
nu-pretty-hex	update nu-ansi-term to 0.50, lscolors to 0.17, and add the Style attribute to Suggestion (#11635 )	2024-01-24 20:57:15 -08:00
nu-protocol	Fix panic in `rotate`; Add safe record creation function (#11718 )	2024-02-03 13:23:16 +02:00
nu-std	cleanup hide testing PR (#11638 )	2024-01-25 06:49:04 -06:00
nu-system	Fix tarpaulin skip attribute to latest (#11552 )	2024-01-17 07:26:34 -06:00
nu-table	update nu-ansi-term to 0.50, lscolors to 0.17, and add the Style attribute to Suggestion (#11635 )	2024-01-24 20:57:15 -08:00
nu-term-grid	Bump to dev version 0.89.1 (#11513 )	2024-01-11 00:19:21 +13:00
nu-test-support	Remove duplicate `which` 4.4.2 (#11613 )	2024-01-22 09:28:47 -06:00
nu-utils	add match-text style + config setting for ide menu (#11670 )	2024-01-29 09:59:01 -06:00
README.md	Remove old nushell/merge engine-q	2022-02-07 14:54:06 -05:00

README.md

Nushell core libraries and plugins

These sub-crates form both the foundation for Nu and a set of plugins which extend Nu with additional functionality.

Foundational libraries are split into two kinds of crates:

Core crates - those crates that work together to build the Nushell language engine
Support crates - a set of crates that support the engine with additional features like JSON support, ANSI support, and more.

Plugins are likewise also split into two types:

Core plugins - plugins that provide part of the default experience of Nu, including access to the system properties, processes, and web-connectivity features.
Extra plugins - these plugins run a wide range of different capabilities like working with different file types, charting, viewing binary data, and more.