mirror of
https://github.com/nushell/nushell.git
synced 2024-11-25 18:03:51 +01:00
c82dfce246
# Description Because the plugin interface reader thread can be responsible for sending a drop notification, it's possible for it to end up in a deadlock where it's waiting for the response to the drop notification call. I decided that the best way to address this is to just discard the response and not wait for it. It's not really important to synchronize with the response to `Dropped`, so this is probably faster anyway. cc @ayax79, this is your issue where polars is getting stuck # User-Facing Changes - A bug fix - Custom value plugin: `custom-value handle update` command # Tests + Formatting Tried to add a test with a long pipeline with a lot of drops and run it over and over to reproduce the deadlock. - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` |
||
|---|---|---|
| .. | ||
| cool_custom_value.rs | ||
| drop_check.rs | ||
| generate2.rs | ||
| generate.rs | ||
| handle_custom_value.rs | ||
| handle_get.rs | ||
| handle_make.rs | ||
| handle_update.rs | ||
| main.rs | ||
| second_custom_value.rs | ||
| update_arg.rs | ||
| update.rs | ||