mirror of
https://github.com/nushell/nushell.git
synced 2025-08-14 12:59:12 +02:00
# Description When implementing a `Command`, one must also import all the types present in the function signatures for `Command`. This makes it so that we often import the same set of types in each command implementation file. E.g., something like this: ```rust use nu_protocol::ast::Call; use nu_protocol::engine::{Command, EngineState, Stack}; use nu_protocol::{ record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, PipelineData, ShellError, Signature, Span, Type, Value, }; ``` This PR adds the `nu_engine::command_prelude` module which contains the necessary and commonly used types to implement a `Command`: ```rust // command_prelude.rs pub use crate::CallExt; pub use nu_protocol::{ ast::{Call, CellPath}, engine::{Command, EngineState, Stack}, record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, IntoSpanned, PipelineData, Record, ShellError, Signature, Span, Spanned, SyntaxShape, Type, Value, }; ``` This should reduce the boilerplate needed to implement a command and also gives us a place to track the breadth of the `Command` API. I tried to be conservative with what went into the prelude modules, since it might be hard/annoying to remove items from the prelude in the future. Let me know if something should be included or excluded.
161 lines
5.7 KiB
Rust
161 lines
5.7 KiB
Rust
use nu_engine::documentation::get_flags_section;
|
|
use nu_protocol::{engine::EngineState, levenshtein_distance};
|
|
use nu_utils::IgnoreCaseExt;
|
|
use reedline::{Completer, Suggestion};
|
|
use std::{fmt::Write, sync::Arc};
|
|
|
|
pub struct NuHelpCompleter(Arc<EngineState>);
|
|
|
|
impl NuHelpCompleter {
|
|
pub fn new(engine_state: Arc<EngineState>) -> Self {
|
|
Self(engine_state)
|
|
}
|
|
|
|
fn completion_helper(&self, line: &str, pos: usize) -> Vec<Suggestion> {
|
|
let full_commands = self.0.get_signatures_with_examples(false);
|
|
let folded_line = line.to_folded_case();
|
|
|
|
//Vec<(Signature, Vec<Example>, bool, bool)> {
|
|
let mut commands = full_commands
|
|
.iter()
|
|
.filter(|(sig, _, _, _, _)| {
|
|
sig.name.to_folded_case().contains(&folded_line)
|
|
|| sig.usage.to_folded_case().contains(&folded_line)
|
|
|| sig
|
|
.search_terms
|
|
.iter()
|
|
.any(|term| term.to_folded_case().contains(&folded_line))
|
|
|| sig.extra_usage.to_folded_case().contains(&folded_line)
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
commands.sort_by(|(a, _, _, _, _), (b, _, _, _, _)| {
|
|
let a_distance = levenshtein_distance(line, &a.name);
|
|
let b_distance = levenshtein_distance(line, &b.name);
|
|
a_distance.cmp(&b_distance)
|
|
});
|
|
|
|
commands
|
|
.into_iter()
|
|
.map(|(sig, examples, _, _, _)| {
|
|
let mut long_desc = String::new();
|
|
|
|
let usage = &sig.usage;
|
|
if !usage.is_empty() {
|
|
long_desc.push_str(usage);
|
|
long_desc.push_str("\r\n\r\n");
|
|
}
|
|
|
|
let extra_usage = &sig.extra_usage;
|
|
if !extra_usage.is_empty() {
|
|
long_desc.push_str(extra_usage);
|
|
long_desc.push_str("\r\n\r\n");
|
|
}
|
|
|
|
let _ = write!(long_desc, "Usage:\r\n > {}\r\n", sig.call_signature());
|
|
|
|
if !sig.named.is_empty() {
|
|
long_desc.push_str(&get_flags_section(Some(&*self.0.clone()), sig, |v| {
|
|
v.to_parsable_string(", ", &self.0.config)
|
|
}))
|
|
}
|
|
|
|
if !sig.required_positional.is_empty()
|
|
|| !sig.optional_positional.is_empty()
|
|
|| sig.rest_positional.is_some()
|
|
{
|
|
long_desc.push_str("\r\nParameters:\r\n");
|
|
for positional in &sig.required_positional {
|
|
let _ = write!(long_desc, " {}: {}\r\n", positional.name, positional.desc);
|
|
}
|
|
for positional in &sig.optional_positional {
|
|
let opt_suffix = if let Some(value) = &positional.default_value {
|
|
format!(
|
|
" (optional, default: {})",
|
|
&value.to_parsable_string(", ", &self.0.config),
|
|
)
|
|
} else {
|
|
(" (optional)").to_string()
|
|
};
|
|
let _ = write!(
|
|
long_desc,
|
|
" (optional) {}: {}{}\r\n",
|
|
positional.name, positional.desc, opt_suffix
|
|
);
|
|
}
|
|
|
|
if let Some(rest_positional) = &sig.rest_positional {
|
|
let _ = write!(
|
|
long_desc,
|
|
" ...{}: {}\r\n",
|
|
rest_positional.name, rest_positional.desc
|
|
);
|
|
}
|
|
}
|
|
|
|
let extra: Vec<String> = examples
|
|
.iter()
|
|
.map(|example| example.example.replace('\n', "\r\n"))
|
|
.collect();
|
|
|
|
Suggestion {
|
|
value: sig.name.clone(),
|
|
description: Some(long_desc),
|
|
style: None,
|
|
extra: Some(extra),
|
|
span: reedline::Span {
|
|
start: pos - line.len(),
|
|
end: pos,
|
|
},
|
|
append_whitespace: false,
|
|
}
|
|
})
|
|
.collect()
|
|
}
|
|
}
|
|
|
|
impl Completer for NuHelpCompleter {
|
|
fn complete(&mut self, line: &str, pos: usize) -> Vec<Suggestion> {
|
|
self.completion_helper(line, pos)
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
use rstest::rstest;
|
|
|
|
#[rstest]
|
|
#[case("who", 5, 8, &["whoami"])]
|
|
#[case("hash", 1, 5, &["hash", "hash md5", "hash sha256"])]
|
|
#[case("into f", 0, 6, &["into float", "into filesize"])]
|
|
#[case("into nonexistent", 0, 16, &[])]
|
|
fn test_help_completer(
|
|
#[case] line: &str,
|
|
#[case] start: usize,
|
|
#[case] end: usize,
|
|
#[case] expected: &[&str],
|
|
) {
|
|
let engine_state =
|
|
nu_command::add_shell_command_context(nu_cmd_lang::create_default_context());
|
|
let mut completer = NuHelpCompleter::new(engine_state.into());
|
|
let suggestions = completer.complete(line, end);
|
|
|
|
assert_eq!(
|
|
expected.len(),
|
|
suggestions.len(),
|
|
"expected {:?}, got {:?}",
|
|
expected,
|
|
suggestions
|
|
.iter()
|
|
.map(|s| s.value.clone())
|
|
.collect::<Vec<_>>()
|
|
);
|
|
|
|
for (exp, actual) in expected.iter().zip(suggestions) {
|
|
assert_eq!(exp, &actual.value);
|
|
assert_eq!(reedline::Span::new(start, end), actual.span);
|
|
}
|
|
}
|
|
}
|