mirror of
https://github.com/nushell/nushell.git
synced 2024-11-25 09:53:43 +01:00
067ceedf79
# Description The intended effect of the `extra` feature has been undermined by introducing the full builds on our release pages and having more activity on some of the extra commands. To simplify the feature matrix let's get rid of it and focus our effort on truly either refining a command to well-specified behavior or discarding it entirely from the `nu` binary and moving it into plugins. ## Details - Remove `--features extra` from CI - Don't explicitly name `extra` in full build wf - Remove feature extra from build-help scripts - Update README in `nu-cmd-extra` - Remove feature `extra` - Fix previously dead `format pattern` tests - Relax signature of `to html` - Fix/ignore `html::test_no_color_flag` - Remove dead features from `version` - Refine `to html` type signature # User-Facing Changes The commands that were previously only available when building with `--features extra` will now be available to everyone. This increases the number of dependencies slightly but has a limited impact on the overall binary size. # Tests + Formatting Some tests that were left in `nu-command` during cratification were dead because the feature was not passed to `nu-command` and only to `nu-cmd-lang` for feature-flag mention in `version`. Those tests have now been either fixed or ignored in one case. # After Submitting There may be places in the documentation where we point to `--features extra` that will now be moot (apart from the generated command help)
186 lines
4.4 KiB
Rust
186 lines
4.4 KiB
Rust
mod test_bits;
|
|
mod test_cell_path;
|
|
mod test_commandline;
|
|
mod test_conditionals;
|
|
mod test_config;
|
|
mod test_config_path;
|
|
mod test_converters;
|
|
mod test_custom_commands;
|
|
mod test_engine;
|
|
mod test_env;
|
|
mod test_help;
|
|
mod test_hiding;
|
|
mod test_ide;
|
|
mod test_iteration;
|
|
mod test_known_external;
|
|
mod test_math;
|
|
mod test_modules;
|
|
mod test_parser;
|
|
mod test_ranges;
|
|
mod test_regex;
|
|
mod test_signatures;
|
|
mod test_spread;
|
|
mod test_stdlib;
|
|
mod test_strings;
|
|
mod test_table_operations;
|
|
mod test_type_check;
|
|
|
|
use assert_cmd::prelude::*;
|
|
use pretty_assertions::assert_eq;
|
|
use std::collections::HashMap;
|
|
use std::io::Write;
|
|
use std::process::Command;
|
|
use tempfile::NamedTempFile;
|
|
|
|
pub type TestResult = Result<(), Box<dyn std::error::Error>>;
|
|
|
|
pub fn run_test_with_env(input: &str, expected: &str, env: &HashMap<&str, &str>) -> TestResult {
|
|
let mut file = NamedTempFile::new()?;
|
|
let name = file.path();
|
|
|
|
let mut cmd = Command::cargo_bin("nu")?;
|
|
cmd.arg(name).envs(env);
|
|
|
|
writeln!(file, "{input}")?;
|
|
|
|
run_cmd_and_assert(cmd, expected)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
pub fn run_test(input: &str, expected: &str) -> TestResult {
|
|
let mut file = NamedTempFile::new()?;
|
|
let name = file.path();
|
|
|
|
let mut cmd = Command::cargo_bin("nu")?;
|
|
cmd.arg("--no-std-lib");
|
|
cmd.arg(name);
|
|
cmd.env(
|
|
"PWD",
|
|
std::env::current_dir().expect("Can't get current dir"),
|
|
);
|
|
|
|
writeln!(file, "{input}")?;
|
|
|
|
run_cmd_and_assert(cmd, expected)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
pub fn run_test_std(input: &str, expected: &str) -> TestResult {
|
|
let mut file = NamedTempFile::new()?;
|
|
let name = file.path();
|
|
|
|
let mut cmd = Command::cargo_bin("nu")?;
|
|
cmd.arg(name);
|
|
cmd.env(
|
|
"PWD",
|
|
std::env::current_dir().expect("Can't get current dir"),
|
|
);
|
|
|
|
writeln!(file, "{input}")?;
|
|
|
|
run_cmd_and_assert(cmd, expected)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
fn run_cmd_and_assert(mut cmd: Command, expected: &str) -> TestResult {
|
|
let output = cmd.output()?;
|
|
|
|
let stderr = String::from_utf8_lossy(&output.stderr).to_string();
|
|
let stdout = String::from_utf8_lossy(&output.stdout).to_string();
|
|
|
|
println!("stdout: {stdout}");
|
|
println!("stderr: {stderr}");
|
|
|
|
assert!(output.status.success());
|
|
|
|
assert_eq!(stdout.trim(), expected);
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
pub fn run_test_contains(input: &str, expected: &str) -> TestResult {
|
|
let mut file = NamedTempFile::new()?;
|
|
let name = file.path();
|
|
|
|
let mut cmd = Command::cargo_bin("nu")?;
|
|
cmd.arg("--no-std-lib");
|
|
cmd.arg(name);
|
|
|
|
writeln!(file, "{input}")?;
|
|
|
|
let output = cmd.output()?;
|
|
|
|
let stderr = String::from_utf8_lossy(&output.stderr).to_string();
|
|
let stdout = String::from_utf8_lossy(&output.stdout).to_string();
|
|
|
|
println!("stdout: {stdout}");
|
|
println!("stderr: {stderr}");
|
|
|
|
println!("Expected output to contain: {expected}");
|
|
assert!(output.status.success());
|
|
|
|
assert!(stdout.contains(expected));
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
pub fn test_ide_contains(input: &str, ide_commands: &[&str], expected: &str) -> TestResult {
|
|
let mut file = NamedTempFile::new()?;
|
|
let name = file.path();
|
|
|
|
let mut cmd = Command::cargo_bin("nu")?;
|
|
cmd.arg("--no-std-lib");
|
|
for ide_command in ide_commands {
|
|
cmd.arg(ide_command);
|
|
}
|
|
cmd.arg(name);
|
|
|
|
writeln!(file, "{input}")?;
|
|
|
|
let output = cmd.output()?;
|
|
|
|
let stderr = String::from_utf8_lossy(&output.stderr).to_string();
|
|
let stdout = String::from_utf8_lossy(&output.stdout).to_string();
|
|
|
|
println!("stdout: {stdout}");
|
|
println!("stderr: {stderr}");
|
|
println!("Expected output to contain: {expected}");
|
|
|
|
assert!(output.status.success());
|
|
|
|
assert!(stdout.contains(expected));
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
pub fn fail_test(input: &str, expected: &str) -> TestResult {
|
|
let mut file = NamedTempFile::new()?;
|
|
let name = file.path();
|
|
|
|
let mut cmd = Command::cargo_bin("nu")?;
|
|
cmd.arg("--no-std-lib");
|
|
cmd.arg(name);
|
|
cmd.env(
|
|
"PWD",
|
|
std::env::current_dir().expect("Can't get current dir"),
|
|
);
|
|
|
|
writeln!(file, "{input}")?;
|
|
|
|
let output = cmd.output()?;
|
|
|
|
let stderr = String::from_utf8_lossy(&output.stderr).to_string();
|
|
let stdout = String::from_utf8_lossy(&output.stdout).to_string();
|
|
|
|
println!("stdout: {stdout}");
|
|
println!("stderr: {stderr}");
|
|
println!("Expected error to contain: {expected}");
|
|
|
|
assert!(!stderr.is_empty() && stderr.contains(expected));
|
|
|
|
Ok(())
|
|
}
|