mirror of
https://github.com/nushell/nushell.git
synced 2024-11-29 20:03:54 +01:00
c039e4b3d0
# Description `split-by` only works on a `Record`, the error type was updated to match, and now uses a more-specific type. (Two type fixes for the price of one!) The `usage` was updated to say "record" as well # User-Facing Changes * Providing the wrong type to `split-by` now gives an error messages with the correct required input type Previously: ``` ❯ ls | get name | split-by type Error: × unsupported input ╭─[entry #267:1:1] 1 │ ls | get name | split-by type · ─┬─ · ╰── requires a table with one row for splitting ╰──── ``` With this PR: ``` ❯ ls | get name | split-by type Error: nu:🐚:type_mismatch × Type mismatch. ╭─[entry #1:1:1] 1 │ ls | get name | split-by type · ─┬─ · ╰── requires a record to split ╰──── ``` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting Only generated commands need to be updated --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
70 lines
1.9 KiB
Rust
70 lines
1.9 KiB
Rust
use nu_test_support::fs::Stub::{EmptyFile, FileWithContentToBeTrimmed};
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn splits() {
|
|
Playground::setup("split_by_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_tres_caballeros.csv",
|
|
r#"
|
|
first_name,last_name,rusty_at,type
|
|
Andrés,Robalino,10/11/2013,A
|
|
JT,Turner,10/12/2013,B
|
|
Yehuda,Katz,10/11/2013,A
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_tres_caballeros.csv
|
|
| group-by rusty_at
|
|
| split-by type
|
|
| get A."10/11/2013"
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "2");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn errors_if_no_input() {
|
|
Playground::setup("split_by_no_input", |dirs, _sandbox| {
|
|
let actual = nu!(cwd: dirs.test(), pipeline("split-by type"));
|
|
|
|
assert!(actual.err.contains("no input value was piped in"));
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn errors_if_non_record_input() {
|
|
Playground::setup("split_by_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![
|
|
EmptyFile("los.txt"),
|
|
EmptyFile("tres.txt"),
|
|
EmptyFile("amigos.txt"),
|
|
EmptyFile("arepas.clu"),
|
|
]);
|
|
|
|
let input_mismatch = nu!(cwd: dirs.test(), pipeline("5 | split-by type"));
|
|
|
|
assert!(input_mismatch.err.contains("doesn't support int input"));
|
|
|
|
let only_supports = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
"
|
|
ls
|
|
| get name
|
|
| split-by type
|
|
"
|
|
));
|
|
|
|
assert!(only_supports
|
|
.err
|
|
.contains("only Record input data is supported"));
|
|
})
|
|
}
|