mirror of
https://github.com/nushell/nushell.git
synced 2025-06-08 19:17:16 +02:00
9996e4a1f8
# Description Continuing from #12568, this PR further reduces the size of `Expr` from 64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and `Type` from 32 to 24 bytes. This was accomplished by: - for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`), merging the fields into new AST struct types and then boxing this struct (e.g. `Expr::Thing(Box<ABC>)`). - replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and `Expression`s should rarely be mutated, if at all, so this optimization makes sense. By reducing the size of these types, I didn't notice a large performance improvement (at least compared to #12568). But this PR does reduce the memory usage of nushell. My config is somewhat light so I only noticed a difference of 1.4MiB (38.9MiB vs 37.5MiB). --------- Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
89 lines
2.6 KiB
Rust
89 lines
2.6 KiB
Rust
use crate::database::{SQLiteDatabase, MEMORY_DB};
|
|
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct StorImport;
|
|
|
|
impl Command for StorImport {
|
|
fn name(&self) -> &str {
|
|
"stor import"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("stor import")
|
|
.input_output_types(vec![(Type::Nothing, Type::table())])
|
|
.required_named(
|
|
"file-name",
|
|
SyntaxShape::String,
|
|
"file name to import the sqlite in-memory database from",
|
|
Some('f'),
|
|
)
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Database)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Import a sqlite database file into the in-memory sqlite database."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["sqlite", "open", "database", "restore", "file"]
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
description: "Import a sqlite database file into the in-memory sqlite database",
|
|
example: "stor import --file-name nudb.sqlite",
|
|
result: None,
|
|
}]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let span = call.head;
|
|
let file_name_opt: Option<String> = call.get_flag(engine_state, stack, "file-name")?;
|
|
let file_name = match file_name_opt {
|
|
Some(file_name) => file_name,
|
|
None => {
|
|
return Err(ShellError::MissingParameter {
|
|
param_name: "please supply a file name with the --file-name parameter".into(),
|
|
span,
|
|
})
|
|
}
|
|
};
|
|
|
|
// Open the in-mem database
|
|
let db = Box::new(SQLiteDatabase::new(std::path::Path::new(MEMORY_DB), None));
|
|
|
|
if let Ok(mut conn) = db.open_connection() {
|
|
db.restore_database_from_file(&mut conn, file_name)
|
|
.map_err(|err| ShellError::GenericError {
|
|
error: "Failed to open SQLite connection in memory from import".into(),
|
|
msg: err.to_string(),
|
|
span: Some(Span::test_data()),
|
|
help: None,
|
|
inner: vec![],
|
|
})?;
|
|
}
|
|
// dbg!(db.clone());
|
|
Ok(Value::custom(db, span).into_pipeline_data())
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(StorImport {})
|
|
}
|
|
}
|