mirror of
https://github.com/nushell/nushell.git
synced 2025-05-30 14:50:02 +02:00
# Description When implementing a `Command`, one must also import all the types present in the function signatures for `Command`. This makes it so that we often import the same set of types in each command implementation file. E.g., something like this: ```rust use nu_protocol::ast::Call; use nu_protocol::engine::{Command, EngineState, Stack}; use nu_protocol::{ record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, PipelineData, ShellError, Signature, Span, Type, Value, }; ``` This PR adds the `nu_engine::command_prelude` module which contains the necessary and commonly used types to implement a `Command`: ```rust // command_prelude.rs pub use crate::CallExt; pub use nu_protocol::{ ast::{Call, CellPath}, engine::{Command, EngineState, Stack}, record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, IntoSpanned, PipelineData, Record, ShellError, Signature, Span, Spanned, SyntaxShape, Type, Value, }; ``` This should reduce the boilerplate needed to implement a command and also gives us a place to track the breadth of the `Command` API. I tried to be conservative with what went into the prelude modules, since it might be hard/annoying to remove items from the prelude in the future. Let me know if something should be included or excluded.
187 lines
6.0 KiB
Rust
187 lines
6.0 KiB
Rust
use crate::dataframe::{
|
|
utils::extract_strings,
|
|
values::{Column, NuDataFrame, NuLazyFrame},
|
|
};
|
|
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct RenameDF;
|
|
|
|
impl Command for RenameDF {
|
|
fn name(&self) -> &str {
|
|
"dfr rename"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Rename a dataframe column."
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build(self.name())
|
|
.required(
|
|
"columns",
|
|
SyntaxShape::Any,
|
|
"Column(s) to be renamed. A string or list of strings",
|
|
)
|
|
.required(
|
|
"new names",
|
|
SyntaxShape::Any,
|
|
"New names for the selected column(s). A string or list of strings",
|
|
)
|
|
.input_output_type(
|
|
Type::Custom("dataframe".into()),
|
|
Type::Custom("dataframe".into()),
|
|
)
|
|
.category(Category::Custom("dataframe or lazyframe".into()))
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Renames a series",
|
|
example: "[5 6 7 8] | dfr into-df | dfr rename '0' new_name",
|
|
result: Some(
|
|
NuDataFrame::try_from_columns(
|
|
vec![Column::new(
|
|
"new_name".to_string(),
|
|
vec![
|
|
Value::test_int(5),
|
|
Value::test_int(6),
|
|
Value::test_int(7),
|
|
Value::test_int(8),
|
|
],
|
|
)],
|
|
None,
|
|
)
|
|
.expect("simple df for test should not fail")
|
|
.into_value(Span::test_data()),
|
|
),
|
|
},
|
|
Example {
|
|
description: "Renames a dataframe column",
|
|
example: "[[a b]; [1 2] [3 4]] | dfr into-df | dfr rename a a_new",
|
|
result: Some(
|
|
NuDataFrame::try_from_columns(
|
|
vec![
|
|
Column::new(
|
|
"a_new".to_string(),
|
|
vec![Value::test_int(1), Value::test_int(3)],
|
|
),
|
|
Column::new(
|
|
"b".to_string(),
|
|
vec![Value::test_int(2), Value::test_int(4)],
|
|
),
|
|
],
|
|
None,
|
|
)
|
|
.expect("simple df for test should not fail")
|
|
.into_value(Span::test_data()),
|
|
),
|
|
},
|
|
Example {
|
|
description: "Renames two dataframe columns",
|
|
example: "[[a b]; [1 2] [3 4]] | dfr into-df | dfr rename [a b] [a_new b_new]",
|
|
result: Some(
|
|
NuDataFrame::try_from_columns(
|
|
vec![
|
|
Column::new(
|
|
"a_new".to_string(),
|
|
vec![Value::test_int(1), Value::test_int(3)],
|
|
),
|
|
Column::new(
|
|
"b_new".to_string(),
|
|
vec![Value::test_int(2), Value::test_int(4)],
|
|
),
|
|
],
|
|
None,
|
|
)
|
|
.expect("simple df for test should not fail")
|
|
.into_value(Span::test_data()),
|
|
),
|
|
},
|
|
]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let value = input.into_value(call.head);
|
|
|
|
if NuLazyFrame::can_downcast(&value) {
|
|
let df = NuLazyFrame::try_from_value(value)?;
|
|
command_lazy(engine_state, stack, call, df)
|
|
} else {
|
|
let df = NuDataFrame::try_from_value(value)?;
|
|
command_eager(engine_state, stack, call, df)
|
|
}
|
|
}
|
|
}
|
|
|
|
fn command_eager(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
mut df: NuDataFrame,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let columns: Value = call.req(engine_state, stack, 0)?;
|
|
let columns = extract_strings(columns)?;
|
|
|
|
let new_names: Value = call.req(engine_state, stack, 1)?;
|
|
let new_names = extract_strings(new_names)?;
|
|
|
|
for (from, to) in columns.iter().zip(new_names.iter()) {
|
|
df.as_mut()
|
|
.rename(from, to)
|
|
.map_err(|e| ShellError::GenericError {
|
|
error: "Error renaming".into(),
|
|
msg: e.to_string(),
|
|
span: Some(call.head),
|
|
help: None,
|
|
inner: vec![],
|
|
})?;
|
|
}
|
|
|
|
Ok(PipelineData::Value(df.into_value(call.head), None))
|
|
}
|
|
|
|
fn command_lazy(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
lazy: NuLazyFrame,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let columns: Value = call.req(engine_state, stack, 0)?;
|
|
let columns = extract_strings(columns)?;
|
|
|
|
let new_names: Value = call.req(engine_state, stack, 1)?;
|
|
let new_names = extract_strings(new_names)?;
|
|
|
|
if columns.len() != new_names.len() {
|
|
let value: Value = call.req(engine_state, stack, 1)?;
|
|
return Err(ShellError::IncompatibleParametersSingle {
|
|
msg: "New name list has different size to column list".into(),
|
|
span: value.span(),
|
|
});
|
|
}
|
|
|
|
let lazy = lazy.into_polars();
|
|
let lazy: NuLazyFrame = lazy.rename(&columns, &new_names).into();
|
|
|
|
Ok(PipelineData::Value(lazy.into_value(call.head)?, None))
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::super::super::test_dataframe::test_dataframe;
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
test_dataframe(vec![Box::new(RenameDF {})])
|
|
}
|
|
}
|