mirror of
https://github.com/nushell/nushell.git
synced 2025-05-28 22:07:40 +02:00
c747ec75c9
# Description
When implementing a `Command`, one must also import all the types
present in the function signatures for `Command`. This makes it so that
we often import the same set of types in each command implementation
file. E.g., something like this:
```rust
use nu_protocol::ast::Call;
use nu_protocol::engine::{Command, EngineState, Stack};
use nu_protocol::{
record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, PipelineData,
ShellError, Signature, Span, Type, Value,
};
```
This PR adds the `nu_engine::command_prelude` module which contains the
necessary and commonly used types to implement a `Command`:
```rust
// command_prelude.rs
pub use crate::CallExt;
pub use nu_protocol::{
ast::{Call, CellPath},
engine::{Command, EngineState, Stack},
record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, IntoSpanned,
PipelineData, Record, ShellError, Signature, Span, Spanned, SyntaxShape, Type, Value,
};
```
This should reduce the boilerplate needed to implement a command and
also gives us a place to track the breadth of the `Command` API. I tried
to be conservative with what went into the prelude modules, since it
might be hard/annoying to remove items from the prelude in the future.
Let me know if something should be included or excluded.
96 lines
2.7 KiB
Rust
96 lines
2.7 KiB
Rust
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct StrJoin;
|
|
|
|
impl Command for StrJoin {
|
|
fn name(&self) -> &str {
|
|
"str join"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("str join")
|
|
.input_output_types(vec![
|
|
(Type::List(Box::new(Type::Any)), Type::String),
|
|
(Type::String, Type::String),
|
|
])
|
|
.optional(
|
|
"separator",
|
|
SyntaxShape::String,
|
|
"Optional separator to use when creating string.",
|
|
)
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Concatenate multiple strings into a single string, with an optional separator between each."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["collect", "concatenate"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let separator: Option<String> = call.opt(engine_state, stack, 0)?;
|
|
|
|
let config = engine_state.get_config();
|
|
|
|
// let output = input.collect_string(&separator.unwrap_or_default(), &config)?;
|
|
// Hmm, not sure what we actually want.
|
|
// `to_formatted_string` formats dates as human readable which feels funny.
|
|
let mut strings: Vec<String> = vec![];
|
|
|
|
for value in input {
|
|
let str = match value {
|
|
Value::Error { error, .. } => {
|
|
return Err(*error);
|
|
}
|
|
Value::Date { val, .. } => format!("{val:?}"),
|
|
value => value.to_expanded_string("\n", config),
|
|
};
|
|
strings.push(str);
|
|
}
|
|
|
|
let output = if let Some(separator) = separator {
|
|
strings.join(&separator)
|
|
} else {
|
|
strings.join("")
|
|
};
|
|
|
|
Ok(Value::string(output, call.head).into_pipeline_data())
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Create a string from input",
|
|
example: "['nu', 'shell'] | str join",
|
|
result: Some(Value::test_string("nushell")),
|
|
},
|
|
Example {
|
|
description: "Create a string from input with a separator",
|
|
example: "['nu', 'shell'] | str join '-'",
|
|
result: Some(Value::test_string("nu-shell")),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(StrJoin {})
|
|
}
|
|
}
|