mirror of
https://github.com/nushell/nushell.git
synced 2024-12-12 18:20:55 +01:00
e530e7d654
This PR closes [Issue #13482](https://github.com/nushell/nushell/issues/13482) # Description This PR tend to make all math function to be constant. # User-Facing Changes The math commands now can be used as constant methods. ### Some Example ``` > const MODE = [3 3 9 12 12 15] | math mode > $MODE ╭───┬────╮ │ 0 │ 3 │ │ 1 │ 12 │ ╰───┴────╯ > const LOG = [16 8 4] | math log 2 > $LOG ╭───┬──────╮ │ 0 │ 4.00 │ │ 1 │ 3.00 │ │ 2 │ 2.00 │ ╰───┴──────╯ > const VAR = [1 3 5] | math variance > $VAR 2.6666666666666665 ``` # Tests + Formatting Tests are added for all of the math command to test there constant behavior. I mostly focused on the actual user experience, not the correctness of the methods and algorithms. # After Submitting I think this change don't require any additional documentation. Feel free to correct me in this topic please.
86 lines
2.4 KiB
Rust
86 lines
2.4 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
use std::str::FromStr;
|
|
|
|
#[test]
|
|
fn all() {
|
|
let sample = r#"
|
|
{
|
|
meals: [
|
|
{description: "1 large egg", calories: 90},
|
|
{description: "1 cup white rice", calories: 250},
|
|
{description: "1 tablespoon fish oil", calories: 108}
|
|
]
|
|
}
|
|
"#;
|
|
|
|
let actual = nu!(pipeline(&format!(
|
|
r#"
|
|
{sample}
|
|
| get meals
|
|
| get calories
|
|
| math sum
|
|
"#
|
|
)));
|
|
|
|
assert_eq!(actual.out, "448");
|
|
}
|
|
|
|
#[test]
|
|
#[allow(clippy::unreadable_literal)]
|
|
#[allow(clippy::float_cmp)]
|
|
fn compute_sum_of_individual_row() -> Result<(), String> {
|
|
let answers_for_columns = [
|
|
("cpu", 88.257434),
|
|
("mem", 3032375296.),
|
|
("virtual", 102579965952.),
|
|
];
|
|
for (column_name, expected_value) in answers_for_columns {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats/",
|
|
format!("open sample-ps-output.json | select {column_name} | math sum | get {column_name}")
|
|
);
|
|
let result =
|
|
f64::from_str(&actual.out).map_err(|_| String::from("Failed to parse float."))?;
|
|
assert_eq!(result, expected_value);
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
#[allow(clippy::unreadable_literal)]
|
|
#[allow(clippy::float_cmp)]
|
|
fn compute_sum_of_table() -> Result<(), String> {
|
|
let answers_for_columns = [
|
|
("cpu", 88.257434),
|
|
("mem", 3032375296.),
|
|
("virtual", 102579965952.),
|
|
];
|
|
for (column_name, expected_value) in answers_for_columns {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats/",
|
|
format!("open sample-ps-output.json | select cpu mem virtual | math sum | get {column_name}")
|
|
);
|
|
let result =
|
|
f64::from_str(&actual.out).map_err(|_| String::from("Failed to parse float."))?;
|
|
assert_eq!(result, expected_value);
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn sum_of_a_row_containing_a_table_is_an_error() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats/",
|
|
"open sample-sys-output.json | math sum"
|
|
);
|
|
assert!(actual
|
|
.err
|
|
.contains("Attempted to compute the sum of a value that cannot be summed"));
|
|
}
|
|
|
|
#[test]
|
|
fn const_sum() {
|
|
let actual = nu!("const SUM = [1 3] | math sum; $SUM");
|
|
assert_eq!(actual.out, "4");
|
|
}
|