mirror of
https://github.com/nushell/nushell.git
synced 2025-05-07 03:24:25 +02:00
9996e4a1f8
# Description Continuing from #12568, this PR further reduces the size of `Expr` from 64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and `Type` from 32 to 24 bytes. This was accomplished by: - for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`), merging the fields into new AST struct types and then boxing this struct (e.g. `Expr::Thing(Box<ABC>)`). - replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and `Expression`s should rarely be mutated, if at all, so this optimization makes sense. By reducing the size of these types, I didn't notice a large performance improvement (at least compared to #12568). But this PR does reduce the memory usage of nushell. My config is somewhat light so I only noticed a difference of 1.4MiB (38.9MiB vs 37.5MiB). --------- Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
81 lines
2.2 KiB
Rust
81 lines
2.2 KiB
Rust
use crate::math::{
|
|
reducers::{reducer_for, Reduce},
|
|
utils::run_with_function,
|
|
};
|
|
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"math product"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("math product")
|
|
.input_output_types(vec![
|
|
(Type::List(Box::new(Type::Number)), Type::Number),
|
|
(Type::Range, Type::Number),
|
|
(Type::table(), Type::record()),
|
|
(Type::record(), Type::record()),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Math)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Returns the product of a list of numbers or the products of each column of a table."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["times", "multiply", "x", "*"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_with_function(call, input, product)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Compute the product of a list of numbers",
|
|
example: "[2 3 3 4] | math product",
|
|
result: Some(Value::test_int(72)),
|
|
},
|
|
Example {
|
|
description: "Compute the product of each column in a table",
|
|
example: "[[a b]; [1 2] [3 4]] | math product",
|
|
result: Some(Value::test_record(record! {
|
|
"a" => Value::test_int(3),
|
|
"b" => Value::test_int(8),
|
|
})),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
/// Calculate product of given values
|
|
pub fn product(values: &[Value], span: Span, head: Span) -> Result<Value, ShellError> {
|
|
let product_func = reducer_for(Reduce::Product);
|
|
product_func(Value::nothing(head), values.to_vec(), span, head)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|