mirror of
https://github.com/nushell/nushell.git
synced 2025-06-01 15:46:04 +02:00
ccd72fa64a
# Description Fixes #8245. Instead of trying to use `nano` or `notepad` as defaults, it errors out if finds that `buffer_editor` , $EDITOR, $VISUAL do not exist. If the PR is landed, Ill update the website as it means what its in there is no longer correct. ``` ❯ config nu Error: × No editor configured ╭─[entry #3:1:1] 1 │ config nu · ────┬──── · ╰── Please specify one via environment variables $EDITOR or $VISUAL ╰──── help: Nushell's config file can be found with the command: $nu.config-path. For more help: (https://nushell.sh/book/configuration.html#configurations-with-built-in-commands) ``` # User-Facing Changes # Tests + Formatting Make sure you've run and fixed any issues with these commands: - [X] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [X] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - [X] `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
71 lines
1.9 KiB
Rust
71 lines
1.9 KiB
Rust
use nu_engine::env_to_strings;
|
|
use nu_protocol::{
|
|
ast::Call,
|
|
engine::{Command, EngineState, Stack},
|
|
Category, Example, PipelineData, ShellError, Signature, Type,
|
|
};
|
|
|
|
use super::utils::{gen_command, get_editor};
|
|
|
|
#[derive(Clone)]
|
|
pub struct ConfigEnv;
|
|
|
|
impl Command for ConfigEnv {
|
|
fn name(&self) -> &str {
|
|
"config env"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build(self.name())
|
|
.category(Category::Env)
|
|
.input_output_types(vec![(Type::Nothing, Type::Nothing)])
|
|
// TODO: Signature narrower than what run actually supports theoretically
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Edit nu environment configurations."
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
description: "allow user to open and update nu env",
|
|
example: "config env",
|
|
result: None,
|
|
}]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let env_vars_str = env_to_strings(engine_state, stack)?;
|
|
let mut config_path = match nu_path::config_dir() {
|
|
Some(path) => path,
|
|
None => {
|
|
return Err(ShellError::GenericError(
|
|
"Could not find nu env path".to_string(),
|
|
"Could not find nu env path".to_string(),
|
|
None,
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
};
|
|
config_path.push("nushell");
|
|
let mut nu_config = config_path.clone();
|
|
nu_config.push("env.nu");
|
|
|
|
let (item, config_args) = get_editor(engine_state, stack, call.head)?;
|
|
|
|
gen_command(call.head, nu_config, item, config_args, env_vars_str).run_with_input(
|
|
engine_state,
|
|
stack,
|
|
input,
|
|
true,
|
|
)
|
|
}
|
|
}
|