extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-12-26 17:09:06 +01:00
Code Issues Packages Projects Releases Wiki Activity
cd0a52cf00
nushell/crates/nu-command/tests/commands/network
History
nibon7 b227eea668
Add checks for ports (#11214) 
# Description
This PR adds checks for ports. This fixes unexpected output similar to
the one in the comment
https://github.com/nushell/nushell/pull/11210#issuecomment-1837152357.

* before

```console
/data/source/nushell> port 65536 99999                                                                                        
41233
```

* after

```console
/data/source/nushell> port 65536 99999                                                                                             
Error: nu:🐚:cant_convert

  × Can't convert to u16.
   ╭─[entry #1:1:1]
 1 │ port 65536 99999
   ·      ──┬──
   ·        ╰── can't convert usize to u16
   ╰────
  help: out of range integral type conversion attempted (min: 0, max: 65535)
```

# User-Facing Changes
N/A

# Tests + Formatting
* [x] add `port_out_of_range` test

# After Submitting
N/A
2023-12-03 08:07:15 -06:00
..
http fix #10319: allow json request of value type list (#10356) 2023-09-13 16:54:03 +02:00
mod.rs Add unit tests for HTTP commands. (#8267) 2023-03-02 11:05:18 -08:00
port.rs Add checks for ports (#11214) 2023-12-03 08:07:15 -06:00