mirror of
https://github.com/nushell/nushell.git
synced 2024-12-28 01:49:20 +01:00
026e18399e
# Description Fixes a bug in `let` where the pipeline wasn't being properly redirected. fixes #9767 # User-Facing Changes Shouldn't have any breaking changes, as this should be better for expected use cases. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
72 lines
1.6 KiB
Rust
72 lines
1.6 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn let_name_builtin_var() {
|
|
let actual = nu!("let in = 3");
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("'in' is the name of a builtin Nushell variable"));
|
|
}
|
|
|
|
#[test]
|
|
fn let_doesnt_mutate() {
|
|
let actual = nu!("let i = 3; $i = 4");
|
|
|
|
assert!(actual.err.contains("immutable"));
|
|
}
|
|
|
|
#[test]
|
|
fn let_takes_pipeline() {
|
|
let actual = nu!(r#"let x = "hello world" | str length; print $x"#);
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn let_pipeline_allows_in() {
|
|
let actual =
|
|
nu!(r#"def foo [] { let x = $in | str length; print ($x + 10) }; "hello world" | foo"#);
|
|
|
|
assert_eq!(actual.out, "21");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_takes_pipeline() {
|
|
let actual = nu!(r#"mut x = "hello world" | str length; print $x"#);
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_pipeline_allows_in() {
|
|
let actual =
|
|
nu!(r#"def foo [] { mut x = $in | str length; print ($x + 10) }; "hello world" | foo"#);
|
|
|
|
assert_eq!(actual.out, "21");
|
|
}
|
|
|
|
#[test]
|
|
fn let_pipeline_redirects_internals() {
|
|
let actual = nu!(r#"let x = echo 'bar'; $x | str length"#);
|
|
|
|
assert_eq!(actual.out, "3");
|
|
}
|
|
|
|
#[test]
|
|
fn let_pipeline_redirects_externals() {
|
|
let actual = nu!(r#"let x = nu --testbin cococo 'bar'; $x | str length"#);
|
|
|
|
assert_eq!(actual.out, "3");
|
|
}
|
|
|
|
#[ignore]
|
|
#[test]
|
|
fn let_with_external_failed() {
|
|
// FIXME: this test hasn't run successfully for a long time. We should
|
|
// bring it back to life at some point.
|
|
let actual = nu!(r#"let x = nu --testbin outcome_err "aa"; echo fail"#);
|
|
|
|
assert!(!actual.out.contains("fail"));
|
|
}
|