mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 16:33:37 +01:00
cbf7feef22
# Description This keeps plugin custom values that have requested drop notification around during the lifetime of a plugin call / stream by sending them to a channel that gets persisted during the lifetime of the call. Before this change, it was very likely that the drop notification would be sent before the plugin ever had a chance to handle the value it received. Tests have been added to make sure this works - see the `custom_values` plugin. cc @ayax79 # User-Facing Changes This is basically just a bugfix, just a slightly big one. However, I did add an `as_mut_any()` function for custom values, to avoid having to clone them. This is a breaking change.
89 lines
2.1 KiB
Rust
89 lines
2.1 KiB
Rust
use crate::CustomValuePlugin;
|
|
use nu_plugin::{EngineInterface, EvaluatedCall, SimplePluginCommand};
|
|
use nu_protocol::{
|
|
record, Category, CustomValue, LabeledError, ShellError, Signature, Span, SyntaxShape, Value,
|
|
};
|
|
use serde::{Deserialize, Serialize};
|
|
|
|
#[derive(Clone, Debug, Serialize, Deserialize)]
|
|
pub struct DropCheckValue {
|
|
pub(crate) msg: String,
|
|
}
|
|
|
|
impl DropCheckValue {
|
|
pub(crate) fn new(msg: String) -> DropCheckValue {
|
|
DropCheckValue { msg }
|
|
}
|
|
|
|
pub(crate) fn into_value(self, span: Span) -> Value {
|
|
Value::custom(Box::new(self), span)
|
|
}
|
|
|
|
pub(crate) fn notify(&self) {
|
|
eprintln!("DropCheckValue was dropped: {}", self.msg);
|
|
}
|
|
}
|
|
|
|
#[typetag::serde]
|
|
impl CustomValue for DropCheckValue {
|
|
fn clone_value(&self, span: Span) -> Value {
|
|
self.clone().into_value(span)
|
|
}
|
|
|
|
fn type_name(&self) -> String {
|
|
"DropCheckValue".into()
|
|
}
|
|
|
|
fn to_base_value(&self, span: Span) -> Result<Value, ShellError> {
|
|
Ok(Value::record(
|
|
record! {
|
|
"msg" => Value::string(&self.msg, span)
|
|
},
|
|
span,
|
|
))
|
|
}
|
|
|
|
fn as_any(&self) -> &dyn std::any::Any {
|
|
self
|
|
}
|
|
|
|
fn as_mut_any(&mut self) -> &mut dyn std::any::Any {
|
|
self
|
|
}
|
|
|
|
fn notify_plugin_on_drop(&self) -> bool {
|
|
// This is what causes Nushell to let us know when the value is dropped
|
|
true
|
|
}
|
|
}
|
|
|
|
pub struct DropCheck;
|
|
|
|
impl SimplePluginCommand for DropCheck {
|
|
type Plugin = CustomValuePlugin;
|
|
|
|
fn name(&self) -> &str {
|
|
"custom-value drop-check"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Generates a custom value that prints a message when dropped"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build(self.name())
|
|
.required("msg", SyntaxShape::String, "the message to print on drop")
|
|
.category(Category::Experimental)
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_plugin: &Self::Plugin,
|
|
_engine: &EngineInterface,
|
|
call: &EvaluatedCall,
|
|
_input: &Value,
|
|
) -> Result<Value, LabeledError> {
|
|
Ok(DropCheckValue::new(call.req(0)?).into_value(call.head))
|
|
}
|
|
}
|