mirror of
https://github.com/nushell/nushell.git
synced 2024-10-16 23:33:49 +02:00
da7f77867a
# Description I noticed that some json values are not parsed at the top level, for example: `null`, `true`, `false`. Although this is a valid json. ``` > "null" | from json Error: × Error while parsing JSON text ╭─[entry #12:1:1] 1 │ "null" | from json · ────┬──── · ╰── error parsing JSON text ╰──── Error: × Error while parsing JSON text ╭──── 1 │ null ╰──── ``` I tried to fix it and it seems to work fine. # User-Facing Changes It should give fewer errors. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace --features=extra` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. Co-authored-by: sholderbach <sholderbach@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| commands | ||
| format_conversions | ||
| main.rs | ||