mirror of
https://github.com/nushell/nushell.git
synced 2025-04-01 19:56:41 +02:00
# Description This PR introduces a switch `--serialize` that allows serializing of types that cannot be deserialized. Right now it only serializes closures as strings in `to toml`, `to json`, `to nuon`, `to text`, some indirect `to html` and `to yaml`. A lot of the changes are just weaving the engine_state through calling functions and the rest is just repetitive way of getting the closure block span and grabbing the span's text. In places where it has to report `<Closure 123>` I changed it to `closure_123`. It always seemed like the `<>` were not very nushell-y. This is still a breaking change. I think this could also help with systematic translation of old config to new config file. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
254 lines
7.9 KiB
Rust
254 lines
7.9 KiB
Rust
use crate::network::http::client::{
|
|
check_response_redirection, http_client, http_parse_redirect_mode, http_parse_url,
|
|
request_add_authorization_header, request_add_custom_headers, request_handle_response,
|
|
request_set_timeout, send_request, HttpBody, RequestFlags,
|
|
};
|
|
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"http delete"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("http delete")
|
|
.input_output_types(vec![(Type::Any, Type::Any)])
|
|
.allow_variants_without_examples(true)
|
|
.required(
|
|
"URL",
|
|
SyntaxShape::String,
|
|
"The URL to fetch the contents from.",
|
|
)
|
|
.named(
|
|
"user",
|
|
SyntaxShape::Any,
|
|
"the username when authenticating",
|
|
Some('u'),
|
|
)
|
|
.named(
|
|
"password",
|
|
SyntaxShape::Any,
|
|
"the password when authenticating",
|
|
Some('p'),
|
|
)
|
|
.named("data", SyntaxShape::Any, "the content to post", Some('d'))
|
|
.named(
|
|
"content-type",
|
|
SyntaxShape::Any,
|
|
"the MIME type of content to post",
|
|
Some('t'),
|
|
)
|
|
.named(
|
|
"max-time",
|
|
SyntaxShape::Duration,
|
|
"max duration before timeout occurs",
|
|
Some('m'),
|
|
)
|
|
.named(
|
|
"headers",
|
|
SyntaxShape::Any,
|
|
"custom headers you want to add ",
|
|
Some('H'),
|
|
)
|
|
.switch(
|
|
"raw",
|
|
"fetch contents as text rather than a table",
|
|
Some('r'),
|
|
)
|
|
.switch(
|
|
"insecure",
|
|
"allow insecure server connections when using SSL",
|
|
Some('k'),
|
|
)
|
|
.switch(
|
|
"full",
|
|
"returns the full response instead of only the body",
|
|
Some('f'),
|
|
)
|
|
.switch(
|
|
"allow-errors",
|
|
"do not fail if the server returns an error code",
|
|
Some('e'),
|
|
).named(
|
|
"redirect-mode",
|
|
SyntaxShape::String,
|
|
"What to do when encountering redirects. Default: 'follow'. Valid options: 'follow' ('f'), 'manual' ('m'), 'error' ('e').",
|
|
Some('R')
|
|
)
|
|
.filter()
|
|
.category(Category::Network)
|
|
}
|
|
|
|
fn description(&self) -> &str {
|
|
"Delete the specified resource."
|
|
}
|
|
|
|
fn extra_description(&self) -> &str {
|
|
"Performs HTTP DELETE operation."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["network", "request", "curl", "wget"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_delete(engine_state, stack, call, input)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "http delete from example.com",
|
|
example: "http delete https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http delete from example.com, with username and password",
|
|
example: "http delete --user myuser --password mypass https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http delete from example.com, with custom header",
|
|
example: "http delete --headers [my-header-key my-header-value] https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http delete from example.com, with body",
|
|
example: "http delete --data 'body' https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "http delete from example.com, with JSON body",
|
|
example:
|
|
"http delete --content-type application/json --data { field: value } https://www.example.com",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Perform an HTTP delete with JSON content from a pipeline to example.com",
|
|
example: "open foo.json | http delete https://www.example.com",
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
struct Arguments {
|
|
url: Value,
|
|
headers: Option<Value>,
|
|
data: HttpBody,
|
|
content_type: Option<String>,
|
|
raw: bool,
|
|
insecure: bool,
|
|
user: Option<String>,
|
|
password: Option<String>,
|
|
timeout: Option<Value>,
|
|
full: bool,
|
|
allow_errors: bool,
|
|
redirect: Option<Spanned<String>>,
|
|
}
|
|
|
|
fn run_delete(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let (data, maybe_metadata) = call
|
|
.get_flag::<Value>(engine_state, stack, "data")?
|
|
.map(|v| (HttpBody::Value(v), None))
|
|
.unwrap_or_else(|| match input {
|
|
PipelineData::Value(v, metadata) => (HttpBody::Value(v), metadata),
|
|
PipelineData::ByteStream(byte_stream, metadata) => {
|
|
(HttpBody::ByteStream(byte_stream), metadata)
|
|
}
|
|
_ => (HttpBody::None, None),
|
|
});
|
|
let content_type = call
|
|
.get_flag(engine_state, stack, "content-type")?
|
|
.or_else(|| maybe_metadata.and_then(|m| m.content_type));
|
|
|
|
let args = Arguments {
|
|
url: call.req(engine_state, stack, 0)?,
|
|
headers: call.get_flag(engine_state, stack, "headers")?,
|
|
data,
|
|
content_type,
|
|
raw: call.has_flag(engine_state, stack, "raw")?,
|
|
insecure: call.has_flag(engine_state, stack, "insecure")?,
|
|
user: call.get_flag(engine_state, stack, "user")?,
|
|
password: call.get_flag(engine_state, stack, "password")?,
|
|
timeout: call.get_flag(engine_state, stack, "max-time")?,
|
|
full: call.has_flag(engine_state, stack, "full")?,
|
|
allow_errors: call.has_flag(engine_state, stack, "allow-errors")?,
|
|
redirect: call.get_flag(engine_state, stack, "redirect-mode")?,
|
|
};
|
|
|
|
helper(engine_state, stack, call, args)
|
|
}
|
|
|
|
// Helper function that actually goes to retrieve the resource from the url given
|
|
// The Option<String> return a possible file extension which can be used in AutoConvert commands
|
|
fn helper(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
args: Arguments,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let span = args.url.span();
|
|
let (requested_url, _) = http_parse_url(call, span, args.url)?;
|
|
let redirect_mode = http_parse_redirect_mode(args.redirect)?;
|
|
|
|
let client = http_client(args.insecure, redirect_mode, engine_state, stack)?;
|
|
let mut request = client.delete(&requested_url);
|
|
|
|
request = request_set_timeout(args.timeout, request)?;
|
|
request = request_add_authorization_header(args.user, args.password, request);
|
|
request = request_add_custom_headers(args.headers, request)?;
|
|
|
|
let response = send_request(
|
|
engine_state,
|
|
request.clone(),
|
|
args.data,
|
|
args.content_type,
|
|
call.head,
|
|
engine_state.signals(),
|
|
);
|
|
|
|
let request_flags = RequestFlags {
|
|
raw: args.raw,
|
|
full: args.full,
|
|
allow_errors: args.allow_errors,
|
|
};
|
|
|
|
check_response_redirection(redirect_mode, span, &response)?;
|
|
request_handle_response(
|
|
engine_state,
|
|
stack,
|
|
span,
|
|
&requested_url,
|
|
request_flags,
|
|
response,
|
|
request,
|
|
)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|