mirror of
https://github.com/nushell/nushell.git
synced 2024-11-25 18:03:51 +01:00
8adf3406e5
# Description Fixes: #12690 The issue is happened after https://github.com/nushell/nushell/pull/12056 is merged. It will raise error if user doesn't supply required parameter when run closure with do. And parser adds a `$it` parameter when parsing closure or block expression. I believe the previous behavior is because we allow such syntax on previous version(0.44): ```nushell let x = { print $it } ``` But it's no longer allowed after 0.60. So I think they can be removed. # User-Facing Changes ```nushell let tmp = { let it = 42 print $it } do -c $tmp ``` should be possible again. # Tests + Formatting Added 1 test
76 lines
1.9 KiB
Rust
76 lines
1.9 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn capture_errors_works() {
|
|
let actual = nu!("do -c {$env.use}");
|
|
|
|
eprintln!("actual.err: {:?}", actual.err);
|
|
|
|
assert!(actual.err.contains("column_not_found"));
|
|
}
|
|
|
|
#[test]
|
|
fn capture_errors_works_for_external() {
|
|
let actual = nu!("do -c {nu --testbin fail}");
|
|
assert!(actual.err.contains("External command failed"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_pipeline() {
|
|
let actual = nu!("do -c {nu --testbin fail} | echo `text`");
|
|
assert!(actual.err.contains("External command failed"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -c {nu --testbin fail}; echo `text`"#);
|
|
assert!(actual.err.contains("External command failed"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn do_with_semicolon_break_on_failed_external() {
|
|
let actual = nu!(r#"do { nu --not_exist_flag }; `text`"#);
|
|
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_shell_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -s { open asdfasdf.txt }; "text""#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "text");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_program_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -p { nu -n -c 'exit 1' }; "text""#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "text");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_should_work_for_external_command() {
|
|
let actual = nu!(r#"do -i { nu --testbin fail asdf }; echo post"#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "post");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_works_with_list_stream() {
|
|
let actual = nu!(r#"do -i { ["a", null, "b"] | ansi strip }"#);
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn run_closure_with_it_using() {
|
|
let actual = nu!(r#"let x = {let it = 3; $it}; do $x"#);
|
|
assert!(actual.err.is_empty());
|
|
assert_eq!(actual.out, "3");
|
|
}
|