mirror of
https://github.com/nushell/nushell.git
synced 2025-03-29 17:16:49 +01:00
This PR closes [Issue #13482](https://github.com/nushell/nushell/issues/13482) # Description This PR tend to make all math function to be constant. # User-Facing Changes The math commands now can be used as constant methods. ### Some Example ``` > const MODE = [3 3 9 12 12 15] | math mode > $MODE ╭───┬────╮ │ 0 │ 3 │ │ 1 │ 12 │ ╰───┴────╯ > const LOG = [16 8 4] | math log 2 > $LOG ╭───┬──────╮ │ 0 │ 4.00 │ │ 1 │ 3.00 │ │ 2 │ 2.00 │ ╰───┴──────╯ > const VAR = [1 3 5] | math variance > $VAR 2.6666666666666665 ``` # Tests + Formatting Tests are added for all of the math command to test there constant behavior. I mostly focused on the actual user experience, not the correctness of the methods and algorithms. # After Submitting I think this change don't require any additional documentation. Feel free to correct me in this topic please.
100 lines
2.7 KiB
Rust
100 lines
2.7 KiB
Rust
use crate::math::{
|
|
reducers::{reducer_for, Reduce},
|
|
utils::run_with_function,
|
|
};
|
|
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"math sum"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("math sum")
|
|
.input_output_types(vec![
|
|
(Type::List(Box::new(Type::Number)), Type::Number),
|
|
(Type::List(Box::new(Type::Duration)), Type::Duration),
|
|
(Type::List(Box::new(Type::Filesize)), Type::Filesize),
|
|
(Type::Range, Type::Number),
|
|
(Type::table(), Type::record()),
|
|
(Type::record(), Type::record()),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Math)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Returns the sum of a list of numbers or of each column in a table."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["plus", "add", "total", "+"]
|
|
}
|
|
|
|
fn is_const(&self) -> bool {
|
|
true
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_with_function(call, input, summation)
|
|
}
|
|
|
|
fn run_const(
|
|
&self,
|
|
_working_set: &StateWorkingSet,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_with_function(call, input, summation)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Sum a list of numbers",
|
|
example: "[1 2 3] | math sum",
|
|
result: Some(Value::test_int(6)),
|
|
},
|
|
Example {
|
|
description: "Get the disk usage for the current directory",
|
|
example: "ls | get size | math sum",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Compute the sum of each column in a table",
|
|
example: "[[a b]; [1 2] [3 4]] | math sum",
|
|
result: Some(Value::test_record(record! {
|
|
"a" => Value::test_int(4),
|
|
"b" => Value::test_int(6),
|
|
})),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
pub fn summation(values: &[Value], span: Span, head: Span) -> Result<Value, ShellError> {
|
|
let sum_func = reducer_for(Reduce::Summation);
|
|
sum_func(Value::nothing(head), values.to_vec(), span, head)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|