mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 16:33:37 +01:00
7f2f67238f
# Description This PR updates `group-by` and `split-by` to allow other nushell Values to be used, namely bools. ### Before ```nushell ❯ [false, false, true, false, true, false] | group-by | table -e Error: nu:🐚:cant_convert × Can't convert to string. ╭─[entry #1:1:2] 1 │ [false, false, true, false, true, false] | group-by | table -e · ──┬── · ╰── can't convert bool to string ╰──── ``` ### After ```nushell ❯ [false, false, true, false, true, false] | group-by | table -e ╭───────┬───────────────╮ │ │ ╭───┬───────╮ │ │ false │ │ 0 │ false │ │ │ │ │ 1 │ false │ │ │ │ │ 2 │ false │ │ │ │ │ 3 │ false │ │ │ │ ╰───┴───────╯ │ │ │ ╭───┬──────╮ │ │ true │ │ 0 │ true │ │ │ │ │ 1 │ true │ │ │ │ ╰───┴──────╯ │ ╰───────┴───────────────╯ ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
82 lines
2.1 KiB
Rust
82 lines
2.1 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn groups() {
|
|
let sample = r#"
|
|
[[first_name, last_name, rusty_at, type];
|
|
[Andrés, Robalino, "10/11/2013", A],
|
|
[JT, Turner, "10/12/2013", B],
|
|
[Yehuda, Katz, "10/11/2013", A]]
|
|
"#;
|
|
|
|
let actual = nu!(pipeline(&format!(
|
|
r#"
|
|
{sample}
|
|
| group-by rusty_at
|
|
| get "10/11/2013"
|
|
| length
|
|
"#
|
|
)));
|
|
|
|
assert_eq!(actual.out, "2");
|
|
}
|
|
|
|
#[test]
|
|
fn errors_if_given_unknown_column_name() {
|
|
let sample = r#"{
|
|
"nu": {
|
|
"committers": [
|
|
{"name": "Andrés N. Robalino"},
|
|
{"name": "JT Turner"},
|
|
{"name": "Yehuda Katz"}
|
|
],
|
|
"releases": [
|
|
{"version": "0.2"}
|
|
{"version": "0.8"},
|
|
{"version": "0.9999999"}
|
|
],
|
|
"0xATYKARNU": [
|
|
["Th", "e", " "],
|
|
["BIG", " ", "UnO"],
|
|
["punto", "cero"]
|
|
]
|
|
}
|
|
}
|
|
"#;
|
|
|
|
let actual = nu!(pipeline(&format!(
|
|
r#"'{sample}'
|
|
| from json
|
|
| group-by {{|| get nu.releases.missing_column }}"#
|
|
)));
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|
|
|
|
#[test]
|
|
fn errors_if_column_not_found() {
|
|
let sample = r#"
|
|
[[first_name, last_name, rusty_at, type];
|
|
[Andrés, Robalino, "10/11/2013", A],
|
|
[JT, Turner, "10/12/2013", B],
|
|
[Yehuda, Katz, "10/11/2013", A]]
|
|
"#;
|
|
|
|
let actual = nu!(pipeline(&format!("{sample} | group-by ttype")));
|
|
|
|
assert!(actual.err.contains("did you mean 'type'"),);
|
|
}
|
|
|
|
#[test]
|
|
fn group_by_on_empty_list_returns_empty_record() {
|
|
let actual = nu!("[[a b]; [1 2]] | where false | group-by a");
|
|
assert!(actual.err.is_empty());
|
|
assert!(actual.out.contains("empty record"));
|
|
}
|
|
|
|
#[test]
|
|
fn optional_cell_path_works() {
|
|
let actual = nu!("[{foo: 123}, {foo: 234}, {bar: 345}] | group-by foo? | to nuon");
|
|
let expected = r#"{"123": [[foo]; [123]], "234": [[foo]; [234]]}"#;
|
|
assert_eq!(actual.out, expected)
|
|
}
|