mirror of
https://github.com/nushell/nushell.git
synced 2024-11-23 00:43:33 +01:00
f2b977b9c5
# Description This improves the operation mismatch error in a few ways: * We now detect if the left-hand side of the operation is at fault, and show a simpler error/error message if it is * Removed the unhelpful hint * Updated the error text to make it clear what types are causing the issue   # User-Facing Changes Error texts and spans will change # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-utils/standard_library/tests.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
83 lines
1.7 KiB
Rust
83 lines
1.7 KiB
Rust
use crate::tests::{fail_test, run_test, TestResult};
|
|
|
|
#[test]
|
|
fn contains() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ bar"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn contains_case_insensitive() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ '(?i)BaR'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_contains() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ asdf"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn match_full_line() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ '^foobarbaz$'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_match_full_line() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ '^foobarbaz$'"#, "false")
|
|
}
|
|
|
|
#[test]
|
|
fn starts_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ '^foo'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_starts_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ '^foo'"#, "false")
|
|
}
|
|
|
|
#[test]
|
|
fn ends_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ 'baz$'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_ends_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ 'baz$'"#, "false")
|
|
}
|
|
|
|
#[test]
|
|
fn where_works() -> TestResult {
|
|
run_test(
|
|
r#"[{name: somefile.txt} {name: anotherfile.csv }] | where name =~ ^s | get name.0"#,
|
|
"somefile.txt",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn where_not_works() -> TestResult {
|
|
run_test(
|
|
r#"[{name: somefile.txt} {name: anotherfile.csv }] | where name !~ ^s | get name.0"#,
|
|
"anotherfile.csv",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_regex_fails() -> TestResult {
|
|
fail_test(r#"'foo' =~ '['"#, "Invalid character class")
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_not_regex_fails() -> TestResult {
|
|
fail_test(r#"'foo' !~ '['"#, "Invalid character class")
|
|
}
|
|
|
|
#[test]
|
|
fn regex_on_int_fails() -> TestResult {
|
|
fail_test(r#"33 =~ foo"#, "is not supported")
|
|
}
|
|
|
|
#[test]
|
|
fn not_regex_on_int_fails() -> TestResult {
|
|
fail_test(r#"33 !~ foo"#, "is not supported")
|
|
}
|