Files
nushell/crates/nu-command/tests/commands/math/round.rs
Bahex 5478ec44bb to <format>: preserve round float numbers' type (#16016)
- fixes #16011

# Description
`Display` implementation for `f64` omits the decimal part for round
numbers, and by using it we did the same.
This affected:
- conversions to delimited formats: `csv`, `tsv`
- textual formats: `html`, `md`, `text`
- pretty printed `json` (`--raw` was unaffected)
- how single float values are displayed in the REPL

> [!TIP]
> This PR fixes our existing json pretty printing implementation.
> We can likely switch to using serde_json's impl using its
PrettyFormatter which allows arbitrary indent strings.

# User-Facing Changes
- Round trips through `csv`, `tsv`, and `json` preserve the type of
round floats.
- It's always clear whether a number is an integer or a float in the
REPL
  ```nushell
  4 / 2
  # => 2  # before: is this an int or a float?

  4 / 2
  # => 2.0  # after: clearly a float
  ``` 

# Tests + Formatting
Adjusted tests for the new behavior.

- 🟢 toolkit fmt
- 🟢 toolkit clippy
- 🟢 toolkit test
- 🟢 toolkit test stdlib

# After Submitting
N/A

---------

Co-authored-by: Bahex <17417311+Bahex@users.noreply.github.com>
2025-06-26 15:15:19 -05:00

58 lines
1.3 KiB
Rust

use nu_test_support::nu;
#[test]
fn can_round_very_large_numbers() {
let actual = nu!("18.1372544780074142289927665486772012345 | math round");
assert_eq!(actual.out, "18")
}
#[test]
fn can_round_very_large_numbers_with_precision() {
let actual = nu!("18.13725447800741422899276654867720121457878988 | math round --precision 10");
assert_eq!(actual.out, "18.137254478")
}
#[test]
fn can_round_integer_with_negative_precision() {
let actual = nu!("123 | math round --precision -1");
assert_eq!(actual.out, "120.0")
}
#[test]
fn can_round_float_with_negative_precision() {
let actual = nu!("123.3 | math round --precision -1");
assert_eq!(actual.out, "120.0")
}
#[test]
fn fails_with_wrong_input_type() {
let actual = nu!("\"not_a_number\" | math round");
assert!(actual.err.contains("command doesn't support"))
}
#[test]
fn const_round() {
let actual = nu!("const ROUND = 18.345 | math round; $ROUND");
assert_eq!(actual.out, "18");
}
#[test]
fn can_round_range_into_list() {
let actual = nu!("(1.0)..(1.2)..(2.0) | math round");
let expected = nu!("[1 1 1 2 2 2]");
assert_eq!(actual.out, expected.out);
}
#[test]
fn cannot_round_infinite_range() {
let actual = nu!("0.. | math round");
assert!(actual.err.contains("nu::shell::incorrect_value"));
}