mirror of
https://github.com/nushell/nushell.git
synced 2025-01-04 21:40:08 +01:00
cc9f41e553
# Description
Kind of a vague title, but this PR does two main things:
1. Rather than overriding functions like `Command::is_parser_keyword`,
this PR instead changes commands to override `Command::command_type`.
The `CommandType` returned by `Command::command_type` is then used to
automatically determine whether `Command::is_parser_keyword` and the
other `is_{type}` functions should return true. These changes allow us
to remove the `CommandType::Other` case and should also guarantee than
only one of the `is_{type}` functions on `Command` will return true.
2. Uses the new, reworked `Command::command_type` function in the `scope
commands` and `which` commands.
# User-Facing Changes
- Breaking change for `scope commands`: multiple columns (`is_builtin`,
`is_keyword`, `is_plugin`, etc.) have been merged into the `type`
column.
- Breaking change: the `which` command can now report `plugin` or
`keyword` instead of `built-in` in the `type` column. It may also now
report `external` instead of `custom` in the `type` column for known
`extern`s.
|
||
|---|---|---|
| .. | ||
| deparse.rs | ||
| exportable.rs | ||
| flatten.rs | ||
| known_external.rs | ||
| lex.rs | ||
| lib.rs | ||
| lite_parser.rs | ||
| parse_keywords.rs | ||
| parse_patterns.rs | ||
| parse_shape_specs.rs | ||
| parser_path.rs | ||
| parser.rs | ||
| type_check.rs | ||